On Thu, Aug 09, 2018 at 09:16:16PM -0300, Flavio Leitner wrote:
> On Thu, Aug 09, 2018 at 11:50:38AM +0200, Timothy Redaelli wrote:
> > On Wed, 8 Aug 2018 13:49:12 -0300
> > Flavio Leitner <[email protected]> wrote:
> > 
> > > Actually, we also have dependencies in the systemd service
> > > to the network service:
> > > 
> > > [Unit]                                                                    
> > >                           
> > > Description=Open vSwitch Forwarding Unit
> > > After=ovsdb-server.service network-pre.target
> > > systemd-udev-settle.service Before=network.target network.service
> > >                       ^^^^^^^^^^^^^^^ 
> > > 
> > > Looks like that would be gone, right?
> > 
> > I checked and "network.service" is an auto-generated service
> > (systemd-sysv-generator - Unit generator for SysV init scripts)
> > from /etc/rc.d/init.d/network that brings Up and Down the interfaces
> > (if you don't use Network Manager).
> > 
> > The explicit dependency is needed in order to avoid having it to run
> > before openvswitch / ovsdb-server.
> > Moreover it's also harmless to have it when network.service doesn't
> > exists since, in this case, systemd will only ignore the dependency.
> >
> > For example, NetworkManager.service has "Before=network.target
> > network.service" on Fedora Rawhide too, since Fedora Rawhide still have
> > the support for the legacy network scripts (/etc/rc.d/init.d/network, in
> > network-scripts package).
> 
> Alright, thanks for looking into this.
> 
> Acked-by: Flavio Leitner <[email protected]>
> 
> Thanks Timothy.

Thanks Timothy (and Flavio).  Applied to master.  Let me know if you
want it in branch-2.10 (or earlier?).
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to