Hi Simon, On Friday, August 10, 2018 at 4:14 PM, Simon Horman <[email protected]> wrote: >Hi Gavi, > >On 10 August 2018 at 10:30, Gavi Teitz <[email protected]> wrote: >>Continuing work done on improving visibility of a flow's offloaded >>state via dpctl, which was begun in commit d63ca5329ff9 ("dpctl: >>Properly reflect a rule's offloaded to HW state"). >> >>The first commit addresses the initialization of the new dpif_flow >>field 'dp_layer' in dpif-netdev, which was left out in the initial >>commit. >> >>The second commit expands the flow type filter, so that flow dumps >>can be filtered by the full expanded set of flow classifications >>related to the offloaded state. >> >>Results of travis run over this series can be seen here: >>https://travis-ci.org/roidayan/ovs/builds/413934233 >> >I will be mostly out-of-office until the 22nd. >I'd like to defer reviewing this until after I return..
I will be OOO from the 22/8 until the 9/9, so if fixes need to be made I will be unable to respond during that period. The second commit is almost completely unchanged from the prior submission of it I made (I had to squash Aaron Conole’s fix for the build error in dpif-netdev.c (commit b10ac772218a – “dpif-netdev: Use compatible function type to fix broken build”) into it, but other than that it is exactly the same), as the unit test failures it uncovered were due to a problem with commit d63ca5329ff9 - "dpctl: Properly reflect a rule's offloaded to HW state". So if it is possible to try to look at them before the 22nd, I would greatly appreciate it; though if not it can wait, as far as I know there isn’t any specific urgency to push these commits. Thanks, Gavi _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
