sorry, totally missed this e-mail On Thu, Aug 2, 2018 at 2:35 PM, Yi-Hung Wei <[email protected]> wrote:
> On Wed, Aug 1, 2018 at 10:37 PM, Darrell Ball <[email protected]> wrote: > > On Wed, Aug 1, 2018 at 3:46 PM, Yi-Hung Wei <[email protected]> > wrote: > > > > Do these commands need a ‘zone’ keyword > > > > eg) ct-set-zone-limits > > > >> > >> $ ovs-appctl dpctl/ct-set-limits default=10 zone=0,limit=5 > zone=1,limit=3 > > I think I am fine either way. I can change ct-set-zone-limits to > ct-set-limits in later version. > > > > > I wonder if it makes sense to write > > > > ‘zone=default,limit=10’ > > > > so that ‘default’ is treated like any zone? > That makes sense, and I think it does simplify the syntax. Will make > this change in v3. > I can add a quick incremental later as well. > > >> > >> $ ovs-appctl dpct/ct-del-limits zone=0 > > > > > > > > I wonder if we set zone limit to zero (unlimited), it could be like > deleting > > a zone limit. > > > > $ ovs-appctl dpctl/ct-set-limits zone=1,limit=0 > > The default limit may change from time to time, it is not necessarily > to be zero (unlimited). > I understand; more generally: If these special values were strings at the dpctl level then it would be more obvious what I meant. i.e. ovs-appctl dpctl/ct-zone-set-limits zone=1,limit=unlimited ovs-appctl dpctl/ct-zone-set-limits zone=1,limit=default (i.e. "delete") ovs-appctl dpctl/ct-zone-set-limits zone=1,limit=4 The internal values could be unlimited: 0 default: -1 or whatever. > > On the other hand, we may set limit to 'default', such as having > commands like $ ovs-appctl dpctl/ct-set-limits zone=1,limit=default > zone=2,limit=default zone=3,limit=default > But I understand your time constraint, so don't worry about it for your patchset. > > But it seems to be easier to have syntax like $ ovs-appctl > dpctl/ct-del-lmits zone=1,2,3 > > Therefore, I prefer to keep the ct-del-limits command as is. > > > Thanks, > > -Yi-Hung > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
