On Fri, Aug 17, 2018 at 04:45:49PM -0700, Justin Pettit wrote:
>
> > On Aug 10, 2018, at 12:42 PM, Ben Pfaff <[email protected]> wrote:
> >
> > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9424#c4
> > Signed-off-by: Ben Pfaff <[email protected]>
> > ---
> > lib/ofp-group.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/ofp-group.c b/lib/ofp-group.c
> > index f6e5242f5244..62cab725efb5 100644
> > --- a/lib/ofp-group.c
> > +++ b/lib/ofp-group.c
> > @@ -1748,7 +1748,7 @@ ofputil_decode_ofp15_group_desc_reply(struct
> > ofputil_group_desc *gd,
> > msg, gd->type, OFPGC15_ADD, &gd->props,
> > length - sizeof *ogds - bucket_list_len);
> > if (error) {
> > - ofputil_bucket_list_destroy(&gd->buckets);
> > + ofputil_uninit_group_desc(gd);
>
> This isn't related to this patch per se, but should
> ofputil_group_properties_destroy() should free "gp->selection_method"?
No:
struct ofputil_group_props {
/* NTR selection method */
char selection_method[NTR_MAX_SELECTION_METHOD_LEN];
uint64_t selection_method_param;
struct field_array fields;
};
> Acked-by: Justin Pettit <[email protected]>
Thanks, I applied this to master and backported as far as applicable.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
