> On Tue, 21 Aug 2018 at 11:19, Ben Pfaff <[email protected]> wrote: > > > On Tue, Aug 21, 2018 at 05:57:47PM +0300, Alin Gabriel Serdean wrote: > > > The daemon-windows file is missing a `set_detach` routine, so add it. > > > > > > This will be useful in the long run. > > > > > > Signed-off-by: Alin Gabriel Serdean <[email protected]> > > > > Thank you for maintaining the Windows port. We could not do it > > without you. > > > > There is a misspelling in the subject: s/deatch/detach/. Sorry for the typo 😊. I'll send a V2 > > > > I don't entirely understand the implications of this patch. Guru, I > > believe that you were involved in the design of --service. Do you > > have any comments? > > > I do not see a need for this. But I don't see a harm either. I suppose Alin > forsees a need for this in the future. I am ok with a merge. > I think this will be make the code a bit simpler for both type of developers. If someone uses get_detach (either for `--service` or `--detach`) they know about the users intention. i.e.: https://github.com/openvswitch/ovs/blob/master/ovn/utilities/ovn-nbctl.c#L183 > > > > For myself: > > Acked-by: Ben Pfaff <[email protected]> > > > > Thanks, > > > > Ben. > > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
