On Wed, Sep 05, 2018 at 09:31:01PM -0700, Justin Pettit wrote:
> In ACL rate-limiting test, we send three sets of 100 packets. One of
> the sets drops packets at a rate of 10 per second, one at a rate of 5
> per second, and one not at all. On my setup, it takes roughly 0.67
> seconds to send those 300 packets, but we have reports of it taking over
> 15 seconds on others. The test was intended to allow some flexibility
> in run-time, but it's very difficult to design a mechanism that can all
> possibilities.
>
> To prevent false test failures, this patch changes the test to check
> the duration count of the meter, and if it's greater than nine seconds,
> just skip the test.
>
> Signed-off-by: Justin Pettit <[email protected]>
> Reported-by: Thomas Goirand <[email protected]>
Around here, I recommend adding an "echo" something like this:
echo "meter duration $d_secs"
That way, if the meter gets skipped, it's easier to find out how long it
actually took.
> +# On particularly slow or overloaded systems, the transmission rate may
> +# be lower than the configured meter rate. To prevent false test
> +# failures, we check the duration count of the meter, and if it's
> +# greater than nine seconds, just skip the test.
> +d_secs=$(as hv ovs-ofctl -O OpenFlow13 meter-stats br-int | grep "meter:1" |
> sed 's/.* duration:\([[0-9]]\{1,\}\)\.[[0-9]]\+s .*/\1/')
> +AT_SKIP_IF([test $d_secs -gt 9])
I didn't test this.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
