Bleep bloop. Greetings Keshav Gupta, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has trailing whitespace
#1334 FILE: ofproto/ofproto-dpif-unixctl.man:36:
Prints the dataplane drops for Open vSwitch datapath.
Lines checked: 2492, Warnings: 1, Errors: 0
build:
mv -f ofproto/.deps/ofproto_libofproto_la-netflow.Tpo
ofproto/.deps/ofproto_libofproto_la-netflow.Plo
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT
ofproto/ofproto_libofproto_la-ofproto.lo -MD -MP -MF
ofproto/.deps/ofproto_libofproto_la-ofproto.Tpo -c -o
ofproto/ofproto_libofproto_la-ofproto.lo `test -f 'ofproto/ofproto.c' || echo
'./'`ofproto/ofproto.c
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT
ofproto/ofproto_libofproto_la-ofproto.lo -MD -MP -MF
ofproto/.deps/ofproto_libofproto_la-ofproto.Tpo -c ofproto/ofproto.c -o
ofproto/ofproto_libofproto_la-ofproto.o
mv -f ofproto/.deps/ofproto_libofproto_la-ofproto.Tpo
ofproto/.deps/ofproto_libofproto_la-ofproto.Plo
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT
ofproto/ofproto_libofproto_la-ofproto-dpif.lo -MD -MP -MF
ofproto/.deps/ofproto_libofproto_la-ofproto-dpif.Tpo -c -o
ofproto/ofproto_libofproto_la-ofproto-dpif.lo `test -f 'ofproto/ofproto-dpif.c'
|| echo './'`ofproto/ofproto-dpif.c
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT
ofproto/ofproto_libofproto_la-ofproto-dpif.lo -MD -MP -MF
ofproto/.deps/ofproto_libofproto_la-ofproto-dpif.Tpo -c ofproto/ofproto-dpif.c
-o ofproto/ofproto_libofproto_la-ofproto-dpif.o
ofproto/ofproto-dpif.c: In function 'ofproto_unixctl_dpif_show_drop_stats':
ofproto/ofproto-dpif.c:5810:14: error: declaration of 'i' shadows a previous
local [-Werror=shadow]
for (int i = 1; i < argc; i++) {
^
ofproto/ofproto-dpif.c:5805:9: error: shadowed declaration is here
[-Werror=shadow]
int i;
^
ofproto/ofproto-dpif.c: In function 'ofproto_unixctl_dpif_clear_drop_stats':
ofproto/ofproto-dpif.c:5843:66: error: unused parameter 'argv'
[-Werror=unused-parameter]
int argc OVS_UNUSED, const char *argv[],
^
ofproto/ofproto-dpif.c: At top level:
cc1: error: unrecognized command line option "-Wno-null-pointer-arithmetic"
[-Werror]
cc1: all warnings being treated as errors
make[2]: *** [ofproto/ofproto_libofproto_la-ofproto-dpif.lo] Error 1
make[2]: Leaving directory
`/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make: *** [all] Error 2
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
