On Tue, Sep 18, 2018 at 12:52 AM, Darrell Ball <[email protected]> wrote:
> > > On Mon, Sep 17, 2018 at 9:06 PM, Ben Pfaff <[email protected]> wrote: > >> On Mon, Sep 17, 2018 at 02:05:49PM -0700, Darrell Ball wrote: >> > Add in rcu support for conntrack. At the same time, the array of >> > hmaps is replaced by a cmap. Using a single map also simplifies >> > the handling of nat and allows the removal of the nat_conn map. >> > There is still some cleanup to do and a few things to check. I'll >> > probably split out into several patches later >> > >> > Signed-off-by: Darrell Ball <[email protected]> >> > --- >> > >> > v1->v2: Some synchronization changes; new expiry lists lock. >> > Fix the 4 Travis builds that were failing. >> >> Would you mind dropping the ct-specific locking constructs too? They do >> not add any additional abstraction and they will make it harder to debug >> because the source file name and line number recorded in the ovs_mutex >> will always point to the ct-specific function, not to their callers. >> > > It is a bit of a tradeoff, but sure it is probably better to remove the > wrappers. > > >> >> I haven't fully reviewed this (not sure I'm the right person). >> > > Since you wrote the rcu code, you would be a good candidate :-) > > I did some more cleanups; V3 incoming. > V3 will be superceded. I was able to later optimize by removing the expiry list lock and did some further cleanups, so I'll send a V4. Thanks Darrell > > Thanks Darrell > > >> >> Thanks, >> >> Ben. >> > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
