On Fri, Sep 21, 2018 at 03:45:00PM +0200, Lorenzo Bianconi wrote:
> > Here's a version that improves on these dimensions.  I have not tested
> > it.  What do you think?
> 
> thx for fixing these bits. The patch works properly, just one comment inline

...

> > +        } else {
> > +            ovntrace_node_append(super, OVNTRACE_NODE_ERROR,
> > +                                 "*** no load balancing destination "
> > +                                 "(use --lb-dst)");
> 
> This codepath is hit when you provide --ct option set to 'new' since in the
> switch egress pipeline ct_lb->n_dsts is 0 and lb_dst.family is set to
> AF_UNSPEC (but the processing continues properly). Is it ok to remove it or
> maybe check if pipeline is set to OVNACT_P_INGRESS?

OK, I moved this so that it only triggers if ct_lb->n_dsts != 0, which I
think should avoid the problem.  With that change, I applied it to
master.

Thanks again!
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to