On Wed, Sep 26, 2018 at 3:27 PM Ben Pfaff <b...@ovn.org> wrote:
>
> On Wed, Sep 26, 2018 at 03:08:03PM -0700, Yi-Hung Wei wrote:
> > This patch addresses the issue that the conntrack fields associated
> > with a packet are missing after a packet is resumed by NXT_RESUME.
> > For example, the last rule in the following OpenFlow pipeline is not
> > working without this patch.
> >
> > table=0, arp,in_port=1 action=2
> > table=0, arp,in_port=2 action=1
> > table=0, in_port=2 icmp action=output:1
> > table=0, in_port=1 icmp action=ct(table=1)
> > table=1, icmp action=controller(pause) resubmit(,2)
> > table=2, in_port=1 icmp ct_state=+trk+new action=output:2
> >
> > A unit test is added to prevent regression.
> >
> > Fixes: 77ab5fd2a95b ("Implement serializing the state of packet traversal 
> > in "continuations".")
> > VMware-BZ: #2202764
> > Signed-off-by: Yi-Hung Wei <yihung....@gmail.com>
> > ---
> > v1->v2: A unit test is added.
>
> Thanks for adding a test.  Is there a reason why a test can't be added
> in the "normal" testsuite rather than system-tests?  The regular
> testsuite runs much more often.

Right, it makes more sense to be in the regular testsuite.

I move the test out from system traffic test to the regular testsuite in v3.

https://patchwork.ozlabs.org/patch/975486/

Thanks,

-Yi-Hung
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to