On Thu, Sep 27, 2018 at 12:53 PM Miguel Angel Ajo Pelayo < [email protected]> wrote:
> > > On Wed, Sep 26, 2018 at 11:08 PM Ben Pfaff <[email protected]> wrote: > >> On Wed, Sep 26, 2018 at 04:14:18PM +0530, [email protected] wrote: >> > From: Numan Siddique <[email protected]> >> > >> > With this commit the users can override the default values of >> > the BFD params - min_rx, min_tx, decay_min_rx and mult if desired. >> > This can be useful to debug any issues related to BFD, like BFD >> > state changes seen frequently. >> > >> > ovn-controller checks for the options 'ovn-bfd-min-rx', >> > 'ovn-bfd-min-tx', 'ovn-bfd-decay-min-rx' and 'ovn-bfd-mult' in the >> > external-ids of OpenvSwitch table row and configures these BFD >> > values to the tunnel interfaces. >> > >> > Signed-off-by: Numan Siddique <[email protected]> >> >> Thanks for working to make OVN better. >> >> If this is primarily a debugging interface, would it be better to use >> ovs-appctl commands to adjust these values? >> >> > For both purposes, customers with a busy or high latency network may > eventually have issues with the defaults, for example, experiencing split > brain situations: 2 chassis fighting for a router because they believe they > are master (can't contact each other, but can contact a set of hypervisor > chassis). > > If this has uses outside of debugging, would it be better to make the >> settings centrally configurable instead of via a local-only interface? >> > > This is a good question, and IMHO it would be better to make it centrally > configurable. Numan, what do you think? > Thanks for the review comments. I agree. I am not very sure at this moment if having it in NB DB is better or SB DB. Having it in SB DB avoids ovn-northd to monitor NB DB and put it in SB DB. And CMS can configure these values directly in SB DB. Thoughts on this ? Thanks Numan > >> >> Thanks, >> >> > Thank you Ben!, > > >> Ben. >> _______________________________________________ >> dev mailing list >> [email protected] >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> > > > -- > Miguel Ángel Ajo > OSP / Networking DFG, OVN Squad Engineering > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
