0-day Robot <[email protected]> writes: > Bleep bloop. Greetings Bhargava Shastry, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Author Bhargava Shastry <[email protected]> needs to sign off. > WARNING: Unexpected sign-offs from developers who are not authors or > co-authors or committers: Bhargava Shastry <bshastry at sect.tu-berlin.de> > WARNING: Line is 106 characters long (recommended limit is 79) > #615 FILE: tests/oss-fuzz/expr_parse_target.c:416: > char *error = expr_parse_microflow(ds_cstr(input), &symtab, NULL, NULL, > lookup_atoi_cb, NULL, &uflow); > > Lines checked: 682, Warnings: 2, Errors: 1 > > > build: > libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I > ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra > -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum > -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes > -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers > -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT > ofproto/ofproto_libofproto_la-netflow.lo -MD -MP -MF > ofproto/.deps/ofproto_libofproto_la-netflow.Tpo -c ofproto/netflow.c -o > ofproto/ofproto_libofproto_la-netflow.o > mv -f ofproto/.deps/ofproto_libofproto_la-netflow.Tpo > ofproto/.deps/ofproto_libofproto_la-netflow.Plo > /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H > -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes > -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security > -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align > -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes > -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror > -g -O2 -MT ofproto/ofproto_libofproto_la-ofproto.lo -MD -MP -MF > ofproto/.deps/ofproto_libofproto_la-ofproto.Tpo -c -o > ofproto/ofproto_libofproto_la-ofproto.lo `test -f 'ofproto/ofproto.c' || echo > './'`ofproto/ofproto.c > libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I > ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra > -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum > -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes > -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers > -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT > ofproto/ofproto_libofproto_la-ofproto.lo -MD -MP -MF > ofproto/.deps/ofproto_libofproto_la-ofproto.Tpo -c ofproto/ofproto.c -o > ofproto/ofproto_libofproto_la-ofproto.o > ofproto/ofproto.c: In function 'ofproto_group_mod_finish': > ofproto/ofproto.c:7400:13: error: missing initializer for field 'new_buckets' > of 'struct <anonymous>' [-Werror=missing-field-initializers] > .new_buckets = new_group ? &new_group->buckets : NULL, > ^ > In file included from ofproto/ofproto.c:48:0: > ./include/openvswitch/ofp-monitor.h:135:36: note: 'new_buckets' declared here > const struct ovs_list *new_buckets; > ^ > ofproto/ofproto.c:7401:13: error: missing initializer for field > 'group_existed' of 'struct <anonymous>' [-Werror=missing-field-initializers] > .group_existed = group_collection_n(&ogm->old_groups) > 0, > ^ > In file included from ofproto/ofproto.c:48:0: > ./include/openvswitch/ofp-monitor.h:140:17: note: 'group_existed' declared > here > int group_existed; > ^ > cc1: all warnings being treated as errors > make[2]: *** [ofproto/ofproto_libofproto_la-ofproto.lo] Error 1 > make[2]: Leaving directory > `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace' > make[1]: *** [all-recursive] Error 1 > make[1]: Leaving directory > `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace' > make: *** [all] Error 2 > >
False alarm here. There is a gcc bug that looks like it is impacting the constructor initialization detection (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60784 which I think is the issue here). I'll make sure that the compiler being used is fixed on the bot side. Additionally, it's probably time to prioritize pulling in Ben's suggestion of factoring out 'errors' from the mainline build and being a bit more robust. -Aaron _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
