> On 3 Oct 2018, at 01:37, Ben Pfaff <[email protected]> wrote:
>
> On Tue, Oct 02, 2018 at 06:01:26PM +0300, Alin Gabriel Serdean wrote:
>> Currently all ovn-nbctl (daemon) tests are failing due to the missing
>> call to `service_start` which is required on Windows.
>>
>> Windows lacks fork so we need to pass all arguments, so we can spawn a new
>> process and interpret it properly when calling `service_start`.
>>
>> Signed-off-by: Alin Gabriel Serdean <[email protected]>
>> Acked-by: Ben Pfaff <[email protected]>
>> ---
>> v2: Remove OVS_UNUSED, add acks
>
> I think that this can be made non-Windows specific by rewriting it as
> follows.
>
> diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
> index eabd30308ac2..7e42b53a9079 100644
> --- a/ovn/utilities/ovn-nbctl.c
> +++ b/ovn/utilities/ovn-nbctl.c
>
Thanks for the suggestion and patch Ben. It looks cleaner and it passes the
unit tests.
I sent a new version here:
https://patchwork.ozlabs.org/patch/979499/
<https://patchwork.ozlabs.org/project/openvswitch/list/?series=69239>
Do you mind adding a sign off?
Thanks,
Alin.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
