Ok, I'll check it out. On Thu, Oct 11, 2018 at 2:04 PM Ben Pfaff <b...@ovn.org> wrote:
> I think that there is only one caller of parse_odp_key_mask_attr() that > needs to understand a ufid, which is odp_flow_from_string(). Maybe the > code to parse a ufid could go there instead. > > On Thu, Oct 11, 2018 at 01:53:54PM -0700, Yifeng Sun wrote: > > Thanks for the review. > > > > How about returning a -EINVAL in this case? > > > > On Thu, Oct 11, 2018 at 1:39 PM Ben Pfaff <b...@ovn.org> wrote: > > > > > On Tue, Oct 09, 2018 at 03:39:18PM -0700, Yifeng Sun wrote: > > > > When parse_odp_key_mask_attr runs into ufid, it returns length of > ufid > > > > without appending data into ofpbufs. This commit adds additional > > > > checking for this case. > > > > > > > > Found this bug when debugging > > > > https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10850, > > > > but not certain it is related. > > > > > > > > Signed-off-by: Yifeng Sun <pkusunyif...@gmail.com> > > > > > > Thanks for the fix. > > > > > > It might be better to come up with a way to disallow a ufid here, since > > > it doesn't make sense to put a ufid into a "set" action. > > > > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
