Bleep bloop. Greetings Mary Manohar, I am a robot and I have tried out your patch. Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Mary Manohar <[email protected]> needs to sign off. WARNING: Line lacks whitespace around operator #42 FILE: ovn/utilities/ovn-nbctl.c:646: lr-policy-add ROUTER PRIORITY MATCH ACTION [NEXTHOP]\n\ WARNING: Line lacks whitespace around operator #44 FILE: ovn/utilities/ovn-nbctl.c:648: lr-policy-del ROUTER [PRIORITY [MATCH]]\n\ WARNING: Line lacks whitespace around operator #46 FILE: ovn/utilities/ovn-nbctl.c:650: lr-policy-list ROUTER print policies for ROUTER\n\ WARNING: Line has trailing whitespace #84 FILE: ovn/utilities/ovn-nbctl.c:3434: /* Check if same routing policy already exists. ERROR: Inappropriate bracing around statement #117 FILE: ovn/utilities/ovn-nbctl.c:3467: if (next_hop != NULL) WARNING: Line is 84 characters long (recommended limit is 79) #195 FILE: ovn/utilities/ovn-nbctl.c:3545: print_routing_policy(const struct nbrec_logical_router_policy *policy, struct ds *s) WARNING: Line is 81 characters long (recommended limit is 79) #199 FILE: ovn/utilities/ovn-nbctl.c:3549: ds_put_format(s, "%10ld %50s %15s %25s", policy->priority, policy->match, ERROR: Inappropriate bracing around statement #202 FILE: ovn/utilities/ovn-nbctl.c:3552: } else WARNING: Line is 93 characters long (recommended limit is 79) #203 FILE: ovn/utilities/ovn-nbctl.c:3553: ds_put_format(s, "%10ld %50s %15s", policy->priority, policy->match, policy->action); Lines checked: 257, Warnings: 7, Errors: 3 Please check this out. If you feel there has been an error, please email [email protected] Thanks, 0-day Robot _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
