> On 02.11.2018 12:54, Ian Stokes wrote: <snip>
> > + /* Not all link speeds are defined in the OpenFlow specs e.g. 25 > Gbps. > > + * In that case the speed will not be reported as part of the usual > > + * call to get_features(). Get the link speed of the device and add > it > > + * to the device status in an easy to read string format. > > + */ > > + smap_add_format(args, "link_speed", "%s", > > + > > + netdev_dpdk_link_speed_to_str__(link.link_speed)); > > But why not a simple smap_add() as I suggested for a v2 ? > There is no reason for additional xvasprintf of the constant string. > Apologies Ilya, I missed the removal of the smap_add_format in the first pass, I've sent a new revision with the correct change https://mail.openvswitch.org/pipermail/ovs-dev/2018-November/353548.html Ian _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
