Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#93 FILE: Documentation/ref/index.rst:54:
- `(pdf)
<http://www.openvswitch.org/support/dist-docs/ovs-actions.7.pdf>`__
WARNING: Line is 83 characters long (recommended limit is 79)
#94 FILE: Documentation/ref/index.rst:55:
- `(html)
<http://www.openvswitch.org/support/dist-docs/ovs-actions.7.html>`__
WARNING: Line is 88 characters long (recommended limit is 79)
#95 FILE: Documentation/ref/index.rst:56:
- `(plain text)
<http://www.openvswitch.org/support/dist-docs/ovs-actions.7.txt>`__
WARNING: Line is 80 characters long (recommended limit is 79)
#890 FILE: lib/ovs-actions.xml:450:
<li><code>any</code> or <code>none</code> (65535 or 0xffff; 0xffffffff)</li>
WARNING: Line is 91 characters long (recommended limit is 79)
#910 FILE: lib/ovs-actions.xml:470:
<syntax><code>output(port=<var>port</var>,
max_len=<var>nbytes</var>)</code></syntax>
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1049 FILE: lib/ovs-actions.xml:609:
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1056 FILE: lib/ovs-actions.xml:616:
WARNING: Line is 125 characters long (recommended limit is 79)
#1111 FILE: lib/ovs-actions.xml:671:
<syntax><code>controller(</code><var>key</var>[<code>=</code><var>value</var>]<code>,</code>
...<code>)</code></syntax>
WARNING: Line has trailing whitespace
#1181 FILE: lib/ovs-actions.xml:741:
</conformance>
WARNING: Line is 103 characters long (recommended limit is 79)
#1186 FILE: lib/ovs-actions.xml:746:
<syntax><code>enqueue(</code><var>port</var><code>,</code><var>queue</var><code>)</code></syntax>
WARNING: Line is 89 characters long (recommended limit is 79)
#1187 FILE: lib/ovs-actions.xml:747:
<syntax><code>enqueue:</code><var>port</var><code>:</code><var>queue</var></syntax>
WARNING: Line is 201 characters long (recommended limit is 79)
#1232 FILE: lib/ovs-actions.xml:792:
<syntax><code>bundle(</code><var>fields</var><code>,
</code><var>basis</var><code>, </code><var>algorithm</var><code>,
</code>ofport<code>, slaves:</code><var>port</var>...<code>)</code></syntax>
WARNING: Line is 235 characters long (recommended limit is 79)
#1233 FILE: lib/ovs-actions.xml:793:
<syntax><code>bundle_load(</code><var>fields</var><code>,
</code><var>basis</var><code>, </code><var>algorithm</var><code>,
</code>ofport<code>, </code><var>dst</var><code>,
slaves:</code><var>port</var>...<code>)</code></syntax>
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1283 FILE: lib/ovs-actions.xml:843:
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1408 FILE: lib/ovs-actions.xml:968:
WARNING: Line has trailing whitespace
#1456 FILE: lib/ovs-actions.xml:1016:
Ethertype to <var>ethertype</var>.
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1458 FILE: lib/ovs-actions.xml:1018:
WARNING: Line is 189 characters long (recommended limit is 79)
#1475 FILE: lib/ovs-actions.xml:1035:
<syntax><code>encap(nsh(</code>[<code>md_type=<var>md_type</var></code>]<code>,
</code>[<code>tlv(<var>class</var>,<var>type</var>,<var>value</var>)</code>]...<code>))</code></syntax>
WARNING: Line is 125 characters long (recommended limit is 79)
#1563 FILE: lib/ovs-actions.xml:1123:
<syntax><code>set_field:</code><var>value</var>[<code>/</code><var>mask</var>]<code>-></code><var>dst</var></syntax>
WARNING: Line is 102 characters long (recommended limit is 79)
#1564 FILE: lib/ovs-actions.xml:1124:
<syntax><code>load:</code><var>value</var><code>-></code><var>dst</var><code></code></syntax>
WARNING: Line is 87 characters long (recommended limit is 79)
#1598 FILE: lib/ovs-actions.xml:1158:
<li><code>set_field:01:00:00:00:00:00/01:00:00:00:00:00->eth_dst</code></li>
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1639 FILE: lib/ovs-actions.xml:1199:
WARNING: Line is 105 characters long (recommended limit is 79)
#1676 FILE: lib/ovs-actions.xml:1236:
<code><var>xx</var>:<var>xx</var>:<var>xx</var>:<var>xx</var>:<var>xx</var>:<var>xx</var></code>.
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1752 FILE: lib/ovs-actions.xml:1312:
WARNING: Line is 106 characters long (recommended limit is 79)
#1779 FILE: lib/ovs-actions.xml:1339:
<syntax><code>dec_ttl(<var>id1</var>,
</code>[<code><var>id2</var></code>]...<code>)</code></syntax>
WARNING: Line is 111 characters long (recommended limit is 79)
#1816 FILE: lib/ovs-actions.xml:1376:
<h2>The <code>set_mpls_label</code>, <code>set_mpls_tc</code>, and
<code>set_mpls_ttl</code> actions</h2>
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1839 FILE: lib/ovs-actions.xml:1399:
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1856 FILE: lib/ovs-actions.xml:1416:
WARNING: Line is 81 characters long (recommended limit is 79)
#1858 FILE: lib/ovs-actions.xml:1418:
<h2>The <code>dec_mpls_ttl</code> and <code>dec_nsh_ttl</code>
actions</h2>
WARNING: Line has trailing whitespace
#1893 FILE: lib/ovs-actions.xml:1453:
</p>
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#1920 FILE: lib/ovs-actions.xml:1480:
WARNING: Line is 93 characters long (recommended limit is 79)
#1953 FILE: lib/ovs-actions.xml:1513:
href="https://mailman.stanford.edu/pipermail/openflow-spec/2009-August/000394.html"/>
WARNING: Line is 98 characters long (recommended limit is 79)
#1994 FILE: lib/ovs-actions.xml:1554:
<syntax><code>ct(commit</code>[<code>,
<var>argument</var></code>]...<code>)</code></syntax>
WARNING: Line is 146 characters long (recommended limit is 79)
#2071 FILE: lib/ovs-actions.xml:1631:
<dt><code>nat(<var>type</var>=<var>addrs</var></code>[<code>:<var>ports</var></code>][<code>,<var>flag</var></code>]...<code>)</code></dt>
WARNING: Line is 81 characters long (recommended limit is 79)
#2076 FILE: lib/ovs-actions.xml:1636:
address/port translation (SNAT), or <code>dst</code>, for
destination
WARNING: Line is 80 characters long (recommended limit is 79)
#2077 FILE: lib/ovs-actions.xml:1637:
address/port translation (DNAT). Setting up address translation for
WARNING: Line is 80 characters long (recommended limit is 79)
#2083 FILE: lib/ovs-actions.xml:1643:
The <code>src</code> and <code>dst</code> options take the following
WARNING: Line is 81 characters long (recommended limit is 79)
#2095 FILE: lib/ovs-actions.xml:1655:
as described below. Either IPv4 or IPv6 addresses can be
provided,
WARNING: Line is 80 characters long (recommended limit is 79)
#2099 FILE: lib/ovs-actions.xml:1659:
addresses must be bracketed with <code>[</code> and <code>]</code>
WARNING: Line is 81 characters long (recommended limit is 79)
#2122 FILE: lib/ovs-actions.xml:1682:
The selection of the port from the given range should be done
using
WARNING: Line is 81 characters long (recommended limit is 79)
#2129 FILE: lib/ovs-actions.xml:1689:
The selection of the port from the given range should be done
using
WARNING: Line is 81 characters long (recommended limit is 79)
#2137 FILE: lib/ovs-actions.xml:1697:
The selection of the IP address from the given range should be
done
WARNING: Line is 81 characters long (recommended limit is 79)
#2138 FILE: lib/ovs-actions.xml:1698:
so that the same mapping can be provided after the system
restarts.
WARNING: Line is 81 characters long (recommended limit is 79)
#2144 FILE: lib/ovs-actions.xml:1704:
action that also includes <code>nat</code> with a <code>src</code>
or
WARNING: Line is 80 characters long (recommended limit is 79)
#2146 FILE: lib/ovs-actions.xml:1706:
helper to be NAT-aware. This functionality is datapath specific and
WARNING: Line is 83 characters long (recommended limit is 79)
#2152 FILE: lib/ovs-actions.xml:1712:
translate the packet being processed in the way the connection has
been
WARNING: Line is 83 characters long (recommended limit is 79)
#2154 FILE: lib/ovs-actions.xml:1714:
<code>nat</code> action with <code>src</code> or <code>dst</code>,
when
WARNING: Line is 81 characters long (recommended limit is 79)
#2161 FILE: lib/ovs-actions.xml:1721:
earliest upstream kernel that implemented <code>ct</code> support
for
WARNING: Line is 87 characters long (recommended limit is 79)
#2206 FILE: lib/ovs-actions.xml:1766:
<dt><code>set_field:<var>value</var>[/<var>mask</var>]->ct_mark</code></dt>
WARNING: Line is 88 characters long (recommended limit is 79)
#2214 FILE: lib/ovs-actions.xml:1774:
<dt><code>set_field:<var>value</var>[/<var>mask</var>]->ct_label</code></dt>
WARNING: Line is 97 characters long (recommended limit is 79)
#2549 FILE: lib/ovs-actions.xml:2109:
<url
href="https://mail.openvswitch.org/pipermail/ovs-discuss/2016-June/021694.html"/>.
WARNING: Line is 96 characters long (recommended limit is 79)
#2578 FILE: lib/ovs-actions.xml:2138:
<syntax><code>fin_timeout(<var>key</var>=<var>value</var></code>...<code>)</code></syntax>
WARNING: Line is 152 characters long (recommended limit is 79)
#2624 FILE: lib/ovs-actions.xml:2184:
<syntax><code>resubmit(</code>[<code><var>port</var></code>]<code>,</code>[<code><var>table</var></code>][<code>,ct</code>]<code>)</code></syntax>
WARNING: Line is 156 characters long (recommended limit is 79)
#2832 FILE: lib/ovs-actions.xml:2392:
<syntax><code>multipath(<var>fields</var>, <var>basis</var>,
<var>algorithm</var>, <var>n_links</var>, <var>arg</var>,
<var>dst</var>)</code></syntax>
WARNING: Line is 82 characters long (recommended limit is 79)
#2912 FILE: lib/ovs-actions.xml:2472:
Computes <var>link</var> = hash(<var>flow</var>) %
<var>n_links</var>.
WARNING: Line is 108 characters long (recommended limit is 79)
#2932 FILE: lib/ovs-actions.xml:2492:
Computes <var>link</var> = hash(<var>flow</var>) /
(<code>MAX_HASH</code> / <var>n_links</var>).
WARNING: Line is 153 characters long (recommended limit is 79)
#2954 FILE: lib/ovs-actions.xml:2514:
<var>link</var> = { <var>i</var> such that <var>weights</var>[<var>i</var>]
>= <var>weights</var>[<var>j</var>] for all <var>j</var> != <var>i</var> }
WARNING: Line is 89 characters long (recommended limit is 79)
#3026 FILE: lib/ovs-actions.xml:2586:
<syntax><code>conjunction(<var>id</var>,
<var>k</var>/<var>n</var>)</code></syntax>
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#3065 FILE: lib/ovs-actions.xml:2625:
WARNING: Line is 84 characters long (recommended limit is 79)
#3218 FILE: lib/ovs-actions.xml:2778:
<syntax><code>write_actions(<var>action</var></code>...<code>)</code></syntax>
WARNING: Line is 98 characters long (recommended limit is 79)
#3235 FILE: lib/ovs-actions.xml:2795:
<syntax><code>write_metadata:<var>value</var></code>[<code>/<var>mask</var></code>]</syntax>
Lines checked: 4378, Warnings: 72, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
