Bleep bloop. Greetings Mary Manohar, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#68 FILE: ovn/northd/ovn-northd.c:4642:
if (nexthop == NULL)
WARNING: Line is 80 characters long (recommended limit is 79)
#113 FILE: ovn/northd/ovn-northd.c:4687:
VLOG_WARN_RL(&rl, "No path for routing policy priority %d; next hop %s",
Lines checked: 229, Warnings: 1, Errors: 1
build:
depbase=`echo ovn/controller-vtep/vtep.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I
./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
-Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast
-Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g
-O2 -MT ovn/controller-vtep/vtep.o -MD -MP -MF $depbase.Tpo -c -o
ovn/controller-vtep/vtep.o ovn/controller-vtep/vtep.c &&\
mv -f $depbase.Tpo $depbase.Po
/bin/sh ./libtool --tag=CC --mode=link gcc -std=gnu99 -Wstrict-prototypes
-Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g
-O2 -o ovn/controller-vtep/ovn-controller-vtep
ovn/controller-vtep/binding.o ovn/controller-vtep/gateway.o
ovn/controller-vtep/ovn-controller-vtep.o ovn/controller-vtep/vtep.o
ovn/lib/libovn.la lib/libopenvswitch.la vtep/libvtep.la -lpthread -lrt -lm
-lunbound
libtool: link: gcc -std=gnu99 -Wstrict-prototypes -Wall -Wextra
-Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
-Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
-Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
-fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -o
ovn/controller-vtep/ovn-controller-vtep ovn/controller-vtep/binding.o
ovn/controller-vtep/gateway.o ovn/controller-vtep/ovn-controller-vtep.o
ovn/controller-vtep/vtep.o ovn/lib/.libs/libovn.a lib/.libs/libopenvswitch.a
-lssl -lcrypto -lcap-ng vtep/.libs/libvtep.a -lpthread -lrt -lm -lunbound
depbase=`echo ovn/northd/ovn-northd.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I
./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
-Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast
-Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g
-O2 -MT ovn/northd/ovn-northd.o -MD -MP -MF $depbase.Tpo -c -o
ovn/northd/ovn-northd.o ovn/northd/ovn-northd.c &&\
mv -f $depbase.Tpo $depbase.Po
In file included from ovn/northd/ovn-northd.c:48:0:
ovn/northd/ovn-northd.c: In function ‘build_routing_policy_flow’:
./include/openvswitch/vlog.h:282:14: error: format ‘%d’ expects argument of
type ‘int’, but argument 5 has type ‘int64_t’ [-Werror=format=]
enum vlog_level level__ = LEVEL; \
^
./include/openvswitch/vlog.h:218:31: note: in expansion of macro ‘VLOG_RL’
#define VLOG_WARN_RL(RL, ...) VLOG_RL(RL, VLL_WARN, __VA_ARGS__)
^
ovn/northd/ovn-northd.c:4713:16: note: in expansion of macro ‘VLOG_WARN_RL’
VLOG_WARN_RL(&rl, "lrp_addr not found for routing policy "
^
cc1: all warnings being treated as errors
make[2]: *** [ovn/northd/ovn-northd.o] Error 1
make[2]: Leaving directory
`/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make: *** [all] Error 2
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
