On Tue, Nov 13, 2018 at 7:32 AM Aaron Conole <[email protected]> wrote: > > Hi Han, > > Han Zhou <[email protected]> writes: > > > From: Han Zhou <[email protected]> > > > > When adding a new chassis, if there is an old chassis with same IP > > existed in Encap table, it is allowed to be added today. However, > > allowing it to be added results in problems: > > > > 1. The new chassis cannot work because none of the other chassises > > are able to create tunnel to it, because of the IP confliction > > with already existed tunnel to the old chassis. > > > > 2. All the other chassises will continuously retry creating the tunnel > > and complaining about the error. > > > > So, instead of hiding the problem, it is better to expose it while > > trying to add the second chassis with duplicated IP. This patch > > ensures it from the ovsdb schema. > > > > Signed-off-by: Han Zhou <[email protected]> > > --- > > FWIW, the build-bot blew up with this commit - a number of the ovn tests > are failing with 'make distcheck' > > ----- 8< ----- > > OVN end-to-end tests > > 2653: ovn -- 3 HVs, 1 LS, 3 lports/HV FAILED ( ovs-macros.at:204) > 2654: ovn -- trace 1 LS, 3 LSPs ok > 2655: ovn -- 2 HVs, 4 lports/HV, localnet ports FAILED ( ovs-macros.at:204) > 2656: ovn -- vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS FAILED ( ovs-macros.at:204) > 2657: ovn -- 3 HVs, 1 VIFs/HV, 1 software GW, 1 LS FAILED ( ovs-macros.at:204) > 2658: ovn -- 3 HVs, 3 LS, 3 lports/LS, 1 LR FAILED ( ovs-macros.at:204) > 2659: ovn -- IP relocation using GARP request FAILED ( ovs-macros.at:204) > 2660: ovn -- portsecurity : 3 HVs, 1 LS, 3 lports/HV FAILED ( ovs-macros.at:204) > 2661: ovn -- 2 HVs, 2 LS, 1 lport/LS, 2 peer LRs FAILED ( ovs-macros.at:204) > 2662: ovn -- 1 HV, 1 LS, 2 lport/LS, 1 LR FAILED ( ovs-macros.at:204) > 2663: ovn -- 1 HV, 2 LSs, 1 lport/LS, 1 LR FAILED ( ovs-macros.at:204) > 2664: ovn -- 2 HVs, 3 LS, 1 lport/LS, 2 peer LRs, static routes FAILED ( ovs-macros.at:204) > 2665: ovn -- send gratuitous arp on localnet FAILED ( ovs-macros.at:204) > 2666: ovn -- 2 HVs, 3 LRs connected via LS, static routes FAILED ( ovs-macros.at:204) > 2667: ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS FAILED ( ovs-macros.at:204) > 2668: ovn -- dhcpv6 : 1 HV, 2 LS, 5 LSPs FAILED ( ovs-macros.at:204) > 2669: ovn -- 2 HVs, 2 LRs connected via LS, gateway router FAILED ( ovs-macros.at:204) > 2670: ovn -- icmp_reply: 1 HVs, 2 LSs, 1 lport/LS, 1 LR FAILED ( ovs-macros.at:204) > 2671: ovn -- port state up and down FAILED ( ovs-macros.at:204) > 2672: ovn -- datapath rules added/removed FAILED ( ovs-macros.at:204) > 2673: ovn -- nd_na FAILED ( ovs-macros.at:204) > 2674: ovn -- address sets modification/removal smoke test FAILED ( ovs-macros.at:204) > 2675: ovn -- ipam ok > 2676: ovn -- ipam connectivity FAILED ( ovs-macros.at:204) > 2677: ovn -- ovs-vswitchd restart FAILED ( ovs-macros.at:204) > 2678: ovn -- send arp for nexthop FAILED ( ovs-macros.at:204) > 2679: ovn -- send gratuitous arp for nat ips in localnet FAILED ( ovs-macros.at:204) > 2680: ovn -- send gratuitous arp with nat-addresses router in localnet ok > 2681: ovn -- delete mac bindings ok > 2682: ovn -- conntrack zone allocation FAILED ( ovs-macros.at:204) > 2683: ovn -- tag allocation ok > 2684: ovn -- lsp deletion and broadcast-flow deletion on localnet FAILED ( ovs-macros.at:204) > 2685: ovn -- ACL logging FAILED ( ovs-macros.at:204) > 2686: ovn -- ACL rate-limited logging FAILED ( ovs-macros.at:204) > 2687: ovn -- DSCP marking and meter check FAILED ( ovs-macros.at:204) > 2688: ovn -- read-only sb db:ptcp access ok > 2689: ovn -- read-only sb db:pssl access ok > 2690: ovn -- nb connection/ssl commands ok > 2691: ovn -- sb connection/ssl commands ok > 2692: ovn -- nested containers FAILED ( ovs-macros.at:204) > 2693: ovn -- 3 HVs, 3 LRs connected via LS, source IP based routes FAILED (ovs-macros.at:204) > 2694: ovn -- dns lookup : 1 HV, 2 LS, 2 LSPs/LS FAILED ( ovs-macros.at:204) > 2695: ovn -- 4 HV, 1 LS, 1 LR, packet test with HA distributed router gateway port FAILED (ovs-macros.at:204) > 2696: ovn -- 4 HV, 3 LS, 2 LR, packet test with HA distributed router gateway port FAILED (ovs-macros.at:204) > 2697: ovn -- 1 LR with distributed router gateway port FAILED (ovn.at:8263 ) > 2698: ovn -- send gratuitous arp for NAT rules on distributed router FAILED (ovs-macros.at:204) > 2699: ovn -- IPv6 ND Router Solicitation responder FAILED ( ovs-macros.at:204) > 2700: ovn -- /32 router IP address FAILED ( ovs-macros.at:204) > 2701: ovn -- 2 HVs, 1 lport/HV, localport ports FAILED ( ovs-macros.at:204) > 2702: ovn -- 1 LR with HA distributed router gateway port FAILED ( ovn.at:9177) > 2703: ovn -- send gratuitous ARP for NAT rules on HA distributed router FAILED (ovs-macros.at:204) > 2704: ovn -- ensure one gw controller restart in HA doesn't bounce the master FAILED (ovs-macros.at:204) > 2705: ovn -- IPv6 Neighbor Solicitation for unknown MAC FAILED ( ovs-macros.at:204) > 2706: ovn -- options:requested-chassis for logical port FAILED ( ovs-macros.at:204) > 2707: ovn -- options:requested-chassis with hostname FAILED ( ovs-macros.at:204) > 2708: ovn -- IPv6 periodic RA FAILED ( ovs-macros.at:204) > 2709: ovn -- ACL reject rule test FAILED ( ovs-macros.at:204) > 2710: ovn -- Port Groups FAILED ( ovs-macros.at:204) > 2711: ovn -- ACLs on Port Groups FAILED ( ovs-macros.at:204) > 2712: ovn -- Address Set generation from Port Groups (static addressing) ok > 2713: ovn -- Address Set generation from Port Groups (dynamic addressing) ok > 2714: ovn -- ACL conjunction ok > 2715: ovn -- TTL exceeded FAILED ( ovs-macros.at:204) > 2716: ovn -- router port unreachable FAILED ( ovs-macros.at:204) > 2717: ovn -- ovn-controller exit FAILED ( ovs-macros.at:204) > 2718: ovn -- ovn-controller restart FAILED ( ovs-macros.at:204) > 2719: ovn -- ovn-nbctl duplicate addresses ok > 2720: ovn -- IP packet buffering FAILED ( ovs-macros.at:204) > > OVN northd > > 2721: ovn -- check Gateway_Chassis propagation from NBDB to SBDB ok > 2722: ovn -- check Gateway_Chassis propagation from NBDB to SBDB backwards compatibility ok > 2723: ovn -- check up state of VIF LSP ok > 2724: ovn -- check up state of router LSP linked to a distributed LR ok > 2725: ovn -- check up state of router LSP linked to a gateway LR ok > 2726: ovn -- check up state of router LSP linked to an LRP with set Gateway Chassis ok > 2727: ovn -- check IPv6 RA config propagation to SBDB ok > 2728: ovn -- test unixctl ok > > ovn-nbctl > > 2729: ovn-nbctl - basic switch commands - direct ok > 2730: ovn-nbctl - basic switch commands - daemon ok > 2731: ovn-nbctl - basic logical switch port commands - direct ok > 2732: ovn-nbctl - basic logical switch port commands - daemon ok > 2733: ovn-nbctl - lport addresses - direct ok > 2734: ovn-nbctl - lport addresses - daemon ok > 2735: ovn-nbctl - port security - direct ok > 2736: ovn-nbctl - port security - daemon ok > 2737: ovn-nbctl - ACLs - direct ok > 2738: ovn-nbctl - ACLs - daemon ok > 2739: ovn-nbctl - QoS - direct ok > 2740: ovn-nbctl - QoS - daemon ok > 2741: ovn-nbctl - meters - direct ok > 2742: ovn-nbctl - meters - daemon ok > 2743: ovn-nbctl - NATs - direct ok > 2744: ovn-nbctl - NATs - daemon ok > 2745: ovn-nbctl - LBs - direct ok > 2746: ovn-nbctl - LBs - daemon ok > 2747: ovn-nbctl - LBs IPv6 - direct ok > 2748: ovn-nbctl - LBs IPv6 - daemon ok > 2749: ovn-nbctl - basic logical router commands - direct ok > 2750: ovn-nbctl - basic logical router commands - daemon ok > 2751: ovn-nbctl - basic logical router port commands - direct ok > 2752: ovn-nbctl - basic logical router port commands - daemon ok > 2753: ovn-nbctl - logical router port gateway chassis - direct ok > 2754: ovn-nbctl - logical router port gateway chassis - daemon ok > 2755: ovn-nbctl - logical router port enable and disable - direct ok > 2756: ovn-nbctl - logical router port enable and disable - daemon ok > 2757: ovn-nbctl - routes - direct ok > 2758: ovn-nbctl - routes - daemon ok > 2759: ovn-nbctl - lsp types - direct ok > 2760: ovn-nbctl - lsp types - daemon ok > 2761: ovn-nbctl - connection - direct ok > 2762: ovn-nbctl - connection - daemon ok > 2763: ovn-nbctl - dry run mode - direct ok > 2764: ovn-nbctl - dry run mode - daemon ok > 2765: ovn-nbctl - oneline output - direct ok > 2766: ovn-nbctl - oneline output - daemon ok > 2767: ovn-nbctl - commands parser error paths - direct ok > 2768: ovn-nbctl - commands parser error paths - daemon ok > 2769: ovn-nbctl - port groups - direct ok > 2770: ovn-nbctl - port groups - daemon ok > 2771: ovn-nbctl - extra newlines - direct ok > 2772: ovn-nbctl - extra newlines - daemon ok > 2773: ovn-nbctl - table formatting - direct ok > 2774: ovn-nbctl - table formatting - daemon ok > 2775: ovn-nbctl - port group commands - direct ok > 2776: ovn-nbctl - port group commands - daemon ok > > ovn-sbctl > > 2777: ovn-sbctl - chassis commands FAILED ( ovn-sbctl.at:47) > 2778: ovn-sbctl ok > 2779: ovn-sbctl - connection ok > > ovn-controller > > 2780: ovn-controller - ovn-bridge-mappings FAILED ( ovs-macros.at:204) > 2781: ovn-controller - Chassis external_ids FAILED ( ovs-macros.at:204) > 2782: ovn-controller - change Encap properties FAILED ( ovs-macros.at:204) > 2783: ovn-controller - check sbdb connection ok > > ovn_controller_vtep > > 2784: ovn-controller-vtep - chassis ok > 2785: ovn-controller-vtep - binding 1 ok > 2786: ovn-controller-vtep - binding 2 ok > 2787: ovn-controller-vtep - vtep-lswitch ok > 2788: ovn-controller-vtep - vtep-macs 1 ok > 2789: ovn-controller-vtep - vtep-macs 2 ok > > mcast snooping > > 2790: mcast - check multicasts to trunk ports are not duplicated ok > 2791: mcast - delete the port mdb when vlan configuration changed ok > 2792: mcast - delete the port mdb when port destroyed ok > > packet-type-aware pipeline > > 2793: ptap - legal flow entries in ptap bridge ok > 2794: ptap - triangle bridge setup with L2 and L3 GRE tunnels ok > 2795: ptap - check decap() prerequisits ok > 2796: ptap - check encap/decap VLAN tagged Ethernet frame ok > 2797: ptap - L3 over patch port ok > 2798: ptap - recirculate after packet_type change ok > > network service header (NSH) > > 2799: nsh - matching ok > 2800: nsh - md1 encap over a veth link ok > 2801: nsh - md2 encap over a veth link ok > 2802: nsh - double encap over veth link using groups ok > 2803: nsh - triangle PTAP bridge setup with NSH over vxlan-gpe ok > > ## ------------- ## > ## Test results. ## > ## ------------- ## > > ERROR: 2320 tests were run, > 59 failed unexpectedly. > 387 tests were skipped. > ## -------------------------- ## > ## testsuite.log was created. ## > ## -------------------------- ## > > Please send `tests/testsuite.log' and all information you think might help: > > To: <[email protected]> > Subject: [openvswitch 2.10.90] testsuite: 2653 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2676 2677 2678 2679 2682 2684 2685 2686 2687 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2715 2716 2717 2718 2720 2777 2780 2781 2782 failed > > ----- >8 ----- > > -Aaron
Thanks Aaron. My bad! I can't believe I sent it without regression tests (though I did test the functionality in an end-to-end environment). I'll fix and send v2. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
