> -----Original Message----- > From: Simon Horman [mailto:[email protected]] > Sent: Tuesday, November 13, 2018 9:29 PM > To: Chris Mi <[email protected]> > Cc: [email protected] > Subject: Re: [ovs-dev v2] netdev-tc-offloads: Delete ufid tc mapping in the > right place > > On Mon, Nov 12, 2018 at 11:08:38AM +0900, Chris Mi wrote: > > Currently, the ufid tc mapping is deleted in add_ufid_tc_mapping(). > > But if tc_replace_flower() failed, the old ufid tc mapping will not be > > deleted. If another thread adds the same tc mapping successfully, then > > there will be multiple mappings for the same ifindex, handle and prio. > > > > * V2: > > - Add a wrapper function del_filter_and_ufid_mapping() > > > > Fixes: 9116730db ("netdev-tc-offloads: Add ufid to tc/netdev map") > > Signed-off-by: Chris Mi <[email protected]> > > Reviewed-by: Roi Dayan <[email protected]> > > Thanks Chris, > > I have applied this to master and branch-2.10. > > It looks like the fix is also relevant to branch-2.9 and branch-2.8 but does > not > apply cleanly there. Could you consider posting a backport to those branches? > > Thanks! Hi Simon,
Thanks for applying it. I posted a fix just now, branch-2.8 and 2.9 can use the same fix. But I'm not sure if I used the right email format. Thanks, Chris _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
