On 11/15/2018 04:40 PM, Ophir Munk wrote: > > >> -----Original Message----- >> From: Stokes, Ian [mailto:[email protected]] >> Sent: Wednesday, November 14, 2018 3:16 PM >> To: Kevin Traynor <[email protected]>; [email protected]; Ophir >> Munk <[email protected]>; [email protected] >> Cc: Christian Ehrhardt <[email protected]> >> Subject: RE: [RFC v2 dpdk-latest 1/2] netdev-dpdk: Update for DPDK CRC >> strip flags change. >> >>> - if (dev->hw_ol_features & NETDEV_RX_HW_CRC_STRIP) { >>> - conf.rxmode.offloads |= DEV_RX_OFFLOAD_CRC_STRIP; >>> + if (!(dev->hw_ol_features & NETDEV_RX_HW_CRC_STRIP)) { >>> + conf.rxmode.offloads |= DEV_RX_OFFLOAD_KEEP_CRC; >>> } >> >> Hi Kevin, >> >> Thanks for this series. Technically the behavior from OVS does change here >> as previously if NETDEV_RX_HW_CRC_STRIP wasn't supported we wouldn't >> set DEV_RX_OFFLOAD_KEEP_CRC. For vdevs it could be the case that this >> isn't supported. >>
Hi Ian, previously there was no check to see if STRIP/KEEP was supported but DPDK wasn't strict about it, so it worked. Now DPDK cares, so the check must be added. Will send v3 with check. >> I spotted this testing the net_null pmd, it now fails to init. It's a corner >> case >> for sure but probably should be checked that support is there before >> explicitly setting it. >> > > This case is handled in https://patchwork.ozlabs.org/patch/997879/ > yep, a check needed to be added against device capability, as for example net_null reports not supporting offloads. thanks, Kevin. >> Thanks >> Ian > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
