On Mon, Dec 10, 2018 at 5:48 PM Ben Pfaff <[email protected]> wrote: > On Mon, Nov 19, 2018 at 11:09:21AM -0800, Darrell Ball wrote: > > Acked-by: Justin Pettit <[email protected]> > > Signed-off-by: Darrell Ball <[email protected]> > > Thanks for adding the documentation comment to parse_ipv6_ext_hdrs(). > Please update the documentation comment to describe the return value. >
sure > > I don't see anything that sets *frag_hdr to NULL if there is no fragment > header. This seems risky at best. > Agreed; there is no guarantee the user would check 'nw_frag' before accessing frag_hdr and/or set *frag_hdr to NULL in the caller. > > Thanks, > > Ben. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
