On Tue, Dec 11, 2018 at 05:10:11PM +0200, Alin Gabriel Serdean wrote: > > > > On 10 Dec 2018, at 19:43, Ben Pfaff <[email protected]> wrote: > > > > The daemon tests used files a lot when shell variables were easier to use > > and easier to understand. This commit changes that. > > > > The tests created empty databases that aren't really needed anymore. This > > commit changes them to use the ovsdb-server --no-db option instead. > > > > The tests had a lot of common code for checking the ancestry of processes. > > This commit factors out a new shell function check_ancestors. > > > > The tests tended to use random pidfile names. This switches to just using > > the defaults, which are fine. > > > > The tests didn't check the names of the child processes. This adds those > > checks using the new check_process_name shell function. This should avoid > > regression of the bug fixed by commit 266f79e32c60 ("daemon-unix: Use > > same name for original or restarted children.") > > > > Other minor improvements too. > > > > I only made small updates to the Windows-specific test, because it is hard > > for me to verify. > > > > Acked-by: Alin Gabriel Serdean <[email protected]> > > Signed-off-by: Ben Pfaff <[email protected]> > > --- > > v1->v2: Rebased, added ack. > > v2->v3: Fix some mixups in v2 from muddling two patches together. > > > > tests/daemon-py.at | 218 > > +++++++++++++++++++++++++---------------------------- > > tests/daemon.at | 212 ++++++++++++++++++++++++++++----------------------- > > 2 files changed, 220 insertions(+), 210 deletions(-) > > > > > I did another run of testing on Windows and everything was fine. > > Acked-by: Alin Gabriel Serdean <[email protected]>
Thanks! I applied this to master. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
