On Thu, Nov 22, 2018 at 06:59:15PM +0800, solomon wrote: > After creating a group with hash select type，then we need to insert a new > bucket with weight， > But，it fails. Commands are as following: > > # ovs-ofctl -O OpenFlow15 add-group br0 "group_id=10, type=select, > selection_method=hash,fields=tcp_src, > bucket=bucket_id=10,weight:99,actions=output:1, > bucket=bucket_id=20,weight:199,actions=output:1 " > > # ovs-ofctl -O OpenFlow15 insert-buckets br0 "group_id=10,type=select > command_bucket_id=last,bucket=bucket_id=3,weight=100,actions=output:1" > ovs-ofctl: type is not needed > > # ovs-ofctl -O OpenFlow15 insert-buckets br0 "group_id=10 > command_bucket_id=last,bucket=bucket_id=3,weight=100,actions=output:1" > ovs-ofctl: Only select groups can have bucket weights. > > > This patch can help us. However, for other types that are not select, the > check of the parameters > is not strict, but it does not affect their function, because other types do > not use this weight parameter. > > v1-->v2: > 1. fix warning from 0-day robot. > > Signed-off-by: solomon <[email protected]>
Thanks for the patch! Would you please add a test so that the fix does not regress? _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
