On Wed, Dec 12, 2018 at 11:53:49AM +0100, Lorenzo Bianconi wrote:
> Add the capability to assign just L2 address to IPAM/MACAM since
> in the current implementation either subnet or ipv6_prefix are mandatory
> to enable IPAM
> 
> Tested-by: Yossi Segev <[email protected]>
> Signed-off-by: Lorenzo Bianconi <[email protected]>

Hi Lorenzo, thank you for the patch.

I have one suggestion for the documentation.  It uses text to say that
the column is Boolean, but usually we would allow the documentation
translator to do that by telling it that the value is boolean, with
type='{"type": "boolean"}' inside the <column> tag:

> +      <column name="other_config" key="mac_only">
> +        Boolean value used to request to assign L2 address only if neither
> +        subnet nor ipv6_prefix are specified
> +      </column>
>      </group>

Thanks,

Ben.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to