Aaron Conole wrote:
> solomon <[email protected]> writes:
>
>> After creating a group with hash select type，then we need to insert a new
>> bucket with weight，
>> But，it fails. Commands are as following:
>>
>> # ovs-ofctl -O OpenFlow15 add-group br0 "group_id=10, type=select,
>> selection_method=hash,fields=tcp_src,
>> bucket=bucket_id=10,weight:99,actions=output:1,
>> bucket=bucket_id=20,weight:199,actions=output:1 "
>>
>> # ovs-ofctl -O OpenFlow15 insert-buckets br0 "group_id=10,type=select
>> command_bucket_id=last,bucket=bucket_id=3,weight=100,actions=output:1"
>> ovs-ofctl: type is not needed
>>
>> # ovs-ofctl -O OpenFlow15 insert-buckets br0 "group_id=10
>> command_bucket_id=last,bucket=bucket_id=3,weight=100,actions=output:1"
>> ovs-ofctl: Only select groups can have bucket weights.
>>
>>
>> This patch can help us. However, for other types that are not select, the
>> check of the parameters
>> is not strict, but it does not affect their function, because other types do
>> not use this weight parameter.
>>
>>
>> v2-->v3:
>> 1. add testcase.
>>
>> v1-->v2:
>> 1. fix warning from 0-day robot.
>>
>>
>> Signed-off-by: solomon <[email protected]>
>> ---
>
> Travis build seems to fail with this, and it looks related:
>
> https://travis-ci.org/ovsrobot/ovs/jobs/467942792
>
> But, I haven't taken a look at the code (technically, I'm on a frozen
> swamp somewhere in NH not supposed to be looking after work related
> things, but if you don't tell my wife, I won't either :).
hum，I have get the point which cause the fail. Thanks you.
I will send the new version patch of V4.
../../tests/ofproto.at:690: strip_xids < stdout
--- - 2018-12-14 11:17:41.885100565 +0000
+++
/home/travis/build/ovsrobot/ovs/openvswitch-2.10.90/_build/tests/testsuite.dir/at-groups/946/stdout
2018-12-14 11:17:41.880292101 +0000
@@ -1,3 +1,3 @@
OFPST_GROUP_DESC reply (OF1.5):
-
group_id=1234,type=select,selection_method=hash,bucket=bucket_id:1,weight:100,actions=output:11,bucket=bucket_id:2,weigh
t:100,actions=output:11
+
group_id=1234,type=select,selection_method=hash,bucket=bucket_id:1,weight:100,actions=output:11,bucket=bucket_id:2,weight:100,actions=output:11
--
Thanks
Solomon
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
