On Tue, Dec 18, 2018 at 02:57:24PM +0300, Ilya Maximets wrote: > This fixes 'RECHECK=yes' functionality in case of configured test > range. For example, before the patch following cmdline will result in > running all of the 1000 tests re-checking in case of any failure: > > make -j8 check TESTSUITEFLAGS='1000-1999' RECHECK=yes > > This happens because ranges and pattern matching options has higher > priority than the '--recheck'. > With patch, only failed tests from the range will be re-checked. > > With this patch applied we're dropping support of '--verbose' and > '--trace' options while re-check, but, IMHO, these options makes > sense mostly while debugging individual tests and not much usable > while running recheck of a whole testsuite. > '--jobs' we're resetting each time anyway. > > Not sure if someone overrides default '--directory'. For me it looks > not very useful. Changing the color mode also looks not much > profitable. > > OTOH, re-checking the ranges or keyword matched tests is very useful, > for example, if you're trying to split up single testsuite check in > a few independent CI jobs. > > Signed-off-by: Ilya Maximets <[email protected]>
Thank you very much for this fix. I have been annoyed by this issue for some time now and I hadn't come up with a good solution. I had figured we needed to filter out -k, numbers, and so on, and I think your solution of just not passing any options at all is much better. I applied both patches to master. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
