On 01/11/2019 08:09 AM, Ilya Maximets wrote:
> Typo introduced while making minor refactoring before applying the
> patch.
>
> Fixes logic and the clang build:
>
> lib/vconn.c:707:47: error:
> variable 'deadline' is uninitialized when
> used within its own initialization [-Werror,-Wuninitialized]
> ? time_msec() + deadline
> ^~~~~~~~
>
> Fixes: 04895042e9f6 ("vconn: Allow timeout configuration for blocking
> connection.")
> Signed-off-by: Ilya Maximets <[email protected]>
Acked-by: Kevin Traynor <[email protected]>
> ---
> lib/vconn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vconn.c b/lib/vconn.c
> index 40ebc5818..403461662 100644
> --- a/lib/vconn.c
> +++ b/lib/vconn.c
> @@ -704,7 +704,7 @@ int
> vconn_connect_block(struct vconn *vconn, long long int timeout)
> {
> long long int deadline = (timeout >= 0
> - ? time_msec() + deadline
> + ? time_msec() + timeout
> : LLONG_MAX);
>
> int error;
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
