On 12/12/2018 22:18, Ian Stokes wrote: > From: Sugesh Chandran <[email protected]> > > Currently devices that do not support configuring flow control via the eth_dev > API (e.g. SRIOV VFs) will fail during configuration setup when the interface > is added even if flow control is not requested. This is due to > rte_eth_dev_flow_ctrl_get() being called regardless of whether a flow > control configuration is required. > > Fix this by moving the rte_eth_dev_flow_ctrl_get() call to be part of > the control block that avoids configuring flow control when no change > has occurred. > > Fixes: 413c85a24353 ("netdev-dpdk: Fix failure to configure flow control at > netdev-init.") > Reported-by: [email protected] > Signed-off-by: Sugesh Chandran <[email protected]> > Co-authored-by: Ian Stokes <[email protected]> > Signed-off-by: Ian Stokes <[email protected]> > ---
Hi Ian, I've given this a go and it looks good to me. I can see this is already in master as well, so: Acked-by: Tiago Lam <[email protected]> Tested-by: Tiago Lam <[email protected]> Before the patch I get the error below when trying to add VF, even without enabling flow control, as mentioned in a previous thread: 2019-01-15T16:38:17.487Z|00096|netdev|WARN|dpdk0: could not set configuration (Unknown error -95) 2019-01-15T16:38:17.507Z|00097|netdev_dpdk|INFO|cannot get flow control parameters on port 1, err=-95 With the patch applied on top of branch-2.9 I no longer see the error, and OvS receives the packets. I also run the userspace testsuite and see no regressions. Tiago. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
