On 20.11.2018 19:19, Ilya Maximets wrote: > Conditional EMC insert helps a lot in scenarios with high numbers > of parallel flows, but in current implementation this option affects > all the threads and ports at once. There are scenarios where we have > different number of flows on different ports. For example, if one > of the VMs encapsulates traffic using additional headers, it will > receive large number of flows but only few flows will come out of > this VM. In this scenario it's much faster to use EMC instead of > classifier for traffic from the VM, but it's better to disable EMC > for the traffic which flows to VM. > > To handle above issue introduced 'emc-enable' configurable to > enable/disable EMC on a per-port basis. Ex.: > > ovs-vsctl set interface dpdk0 other_config:emc-enable=false > > EMC probability kept as is and it works for all the ports with > 'emc-enable=true'. > > Signed-off-by: Ilya Maximets <[email protected]> > --- > > It's been a while since the first version. It's available here: > https://patchwork.ozlabs.org/patch/800277/ > > Version 2: > * The main concern was about backward compatibility. Also, there > is no real profit having the per-port probability value. > So, per-port probability switched to per-port 'emc-enable' > configurable. > Global probability kept back and can be used without any changes. > > Documentation/topics/dpdk/bridge.rst | 4 ++ > NEWS | 4 +- > lib/dpif-netdev.c | 79 +++++++++++++++++++++++++--- > vswitchd/vswitch.xml | 19 +++++++ > 4 files changed, 97 insertions(+), 9 deletions(-)
Any thoughts on this? I'm actually using this patch since the first version (more than a year) without any issues. It needs some minor rebase in NEWS part, I'll send v3 soon. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
