On 01/16/2019 11:50 AM, Thomas Monjalon wrote: > 16/01/2019 12:38, Kevin Traynor: >> On 01/16/2019 11:06 AM, Thomas Monjalon wrote: >>> 16/01/2019 11:56, Kevin Traynor: >>>> On 01/16/2019 10:21 AM, Thomas Monjalon wrote: >>>>> But honestly, I doubt you need to talk about representors in this patch. >>>>> The change is to support multi-ports device generally. >>>> >>>> ok, then just need a way to tell OVS user that the new functionality is >>>> existing. >>> >>> Which functionality? closing a port without closing others? >>> It looks like a bug fix to me :) >> >> A bug? NEVER :-) I just mean the code is enabling some new >> functionality for a user, so they should know that it's available now. > > Yes it was a bug: if you close a Chelsio port, it was closing both ports. > Except that, what is the functionality from your point of view?
afaics, hotplug/unplug and multi-port was not intended to be supported in OVS previously but it was not strictly prevented either and it could lead to what you say, so can say that is a bug, at very least in docs. > You think we need to state that multi-ports devices are supported? > Isn't it a statement for release notes? > Yeah, I think now that it would be available and properly supported, it would be good to add into ovs/NEWS. That is normally updated at same time as functionality. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
