On Wed, Jan 16, 2019 at 02:36:50PM -0800, Yifeng Sun wrote:
> In this piece of code, 'struct ofpbuf b' should always point to
> metadata so that metadata can be filled with values through ofpbuf
> operations, like ofpbuf_put_hex and ofpbuf_push_zeros. However,
> ofpbuf_push_zeros may change the data pointer of 'struct ofpbuf b'
> and therefore, metadata will not contain the expected values. This
> patch fixes it.
> 
> Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10863
> Signed-off-by: Yifeng Sun <[email protected]>
> ---
> v1->v2: Fix a bug in previous version, thanks Ben!

Thanks for v2!

We found out from the followup emails to the previous version that the
padding should indeed go at the end, i.e. ofpbuf_put_zeros() instead of
ofpbuf_push_zeros().  So let's fold that in here.

Thanks,

Ben.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to