> On Dec 14, 2018, at 6:16 PM, Ben Pfaff <[email protected]> wrote: > > Test 854 "tunnel_push_pop - action" showed problems in revalidation for > L3 protocol support in its L3 GRE test. L3 packets (that is, packets > without an Ethernet header but only some L3 protocol such as IPv4 or IPv6) > have an Ethernet type that is kept in the dl_type member of the flow, and > the flows that they pass through can cause L3 and L4 fields to be matched. > However, the translation process incorrectly forced the dl_type to be > wildcarded, which caused a contradiction since it's not possible to match > on L3 and L4 fields if the dl_type is not known, and the code in > odp_flow_key_to_flow() and related functions therefore rejected these flows > at revalidation time. > > This commit fixes the problem by treating dl_type the same for L2 and L3 > flows in translation. It also makes odp_flow_key_to_flow__() copy the > Ethernet type that comes from a packet_type field into dl_type, which is > the expected behavior. > > The actual error that this fixes is only visible after applying an upcoming > commit that improves logging for bad datapath flows. > > Signed-off-by: Ben Pfaff <[email protected]>
Acked-by: Justin Pettit <[email protected]> --Justin _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
