On Thu, Jan 17, 2019 at 01:56:43PM -0800, Justin Pettit wrote: > > > On Dec 27, 2018, at 1:41 PM, Ben Pfaff <[email protected]> wrote: > > > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > > index 839fddd99fbe..8d17151a057e 100644 > > --- a/ofproto/ofproto-dpif-xlate.c > > +++ b/ofproto/ofproto-dpif-xlate.c > > @@ -2058,21 +2058,9 @@ mirror_packet(struct xlate_ctx *ctx, struct xbundle > > *xbundle, > > > > /* 'mirrors' is a bit-mask of candidates for mirroring. Iterate as > > long as > > * some candidates remain. */ > > + mirror_mask_t used_mirrors = 0; > > This is very minor, but the comment combined with the similarly declared > variable seems like it could lead to confusion on a quick reading. Maybe > move the declaration up? I know that would slightly break the preferred > style, so feel free to ignore this. > > Acked-by: Justin Pettit <[email protected]>
Thanks for the feedback! I clarified the comment and applied it to master and backported as far as branch-2.7. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
