> On 01/18/2019 08:56 AM, Ilya Maximets wrote: > > Conditional EMC insert helps a lot in scenarios with high numbers of > > parallel flows, but in current implementation this option affects all > > the threads and ports at once. There are scenarios where we have > > different number of flows on different ports. For example, if one of > > the VMs encapsulates traffic using additional headers, it will receive > > large number of flows but only few flows will come out of this VM. In > > this scenario it's much faster to use EMC instead of classifier for > > traffic from the VM, but it's better to disable EMC for the traffic > > which flows to VM. > > > > To handle above issue introduced 'emc-enable' configurable to > > enable/disable EMC on a per-port basis. Ex.: > > > > ovs-vsctl set interface dpdk0 other_config:emc-enable=false > > > > EMC probability kept as is and it works for all the ports with > > 'emc-enable=true'. > > > > Signed-off-by: Ilya Maximets <[email protected]> > > --- > > > > LGTM. > > Acked-by: Kevin Traynor <[email protected]>
Thanks for working on this Ilya. Quite a useful feature. I like that it makes EMC more viable that than completely disabling for all ports, even a few p2p and pvp tests demonstrate the value of it. Given that you've had this deployed for a year yourself and refined it over that period (the code reflects that) and that no issues were found by Kevin or myself in testing I think this is quite a low risk to add for 2.11 so I've pushed this to master. Thanks Ian _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
