Hi Ben/Ian, I understand that the second part of the patch needs more review. But do you think we can atleast merge the first part of this viz https://mail.openvswitch.org/pipermail/ovs-dev/2018-May/346649.html so that to crash and more importantly silent leaks . We can widely review the other part of the code as it might require more indepth testing and review.
What are your suggestions ? Regards Anju -----Original Message----- From: Ben Pfaff [mailto:[email protected]] Sent: Thursday, January 17, 2019 11:39 PM To: Stokes, Ian <[email protected]> Cc: Lam, Tiago <[email protected]>; Anju Thomas <[email protected]>; [email protected] Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action On Wed, Jan 16, 2019 at 11:38:38AM +0000, Stokes, Ian wrote: > > On 16/01/2019 09:30, Anju Thomas wrote: > > > > > > Hi Folks, > > > > > > Are these changes planned to be merged as well? > > > > > > Regards > > > Anju > > > > Hi Anju, > > > > Unfortunately, no. An RFC based on the below was proposed to the > > mailing list here [1], but no discussion / comments happened after > > that. Further discussion and testing would be needed to move this forward... > > > > I wasn't aware of this tbh. It seems like a bug fix so I believe it would be > eligible to be merged for the 2.11 release a(and possibly backported also). > > As it manipulates the dp packets functionality it would need wider testing > and discussion among the community. > > It won't make it upstream this week before we cut for 2.11 I would think but > there is 4 weeks allowed until release where bug fixes are allowed. If > further work continues it could be merged within that window or afterwards > and backported? Bug fixes are welcomed at any time, pre- or post-release. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
