On Mon, Jan 21, 2019 at 11:53:20AM +0000, Adi Nissim wrote: > Hi Simon, > > thank you for the comments > > Is the tnl->flags check necessary? What is the meaning of a match on the > flags if the tunnel type doesn't support that field. Is it possible to > configure such a flow? > > > it is possible to configure such flow, for example GRE tunnel without key is > a possible option and in this case the key flag will not be set. > > this is why the check tnl->flags is needed.
Thanks, that makes sense. > > It seems to me that the code without your patch assumes that the mask is > all-ones, or in other words an exact-match. This is the only match currently > supported by TC flower. > > So I think that checking the mask.tunnel.id is a good idea, but shouldn't the > check be such that OVS: > > 1. Offloads matches that include an exact match on the tunnel id 2. Skips > matching the tunnel id is the mask is 0 (the purpose of this patch) 3. > Rejects offloading flows where the tunnel id mask is neither 0 nor > all-ones > > I will make the necessary changes and send a new patch. Thanks, much appreciated. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
