Ilya Maximets <[email protected]> writes: > Aaron, what do you think about supporting tags like 'Based-on' in ovsrobot ? > For example, patchew in QEMU parses 'Based-on: <Message-Id>' tags. > Maybe we can use patchwork ids or something similar.
I think there's a way to do it without a tag in the commit message. I don't like having a tag for this sort of information in the commit message itself since it isn't useful to preserve in the commit history (and can serve to clutter things up). Currently, we use [PATCH branch-XXX] to imply that the series needs to be based on a specific branch. The ovsrobot automatically creates branches based on patch series. Maybe it makes sense to enhance that so that some subject metadata marker (series-[0-9]+) would automatically check out the series and then apply the patches. This also lets a reviewer know at a glance that the patches are destined to be applied after a specific series which is already posted. One downside is that it's more subject line data. I can't think of others at the moment, but I'm sure there are some. Since the robot doesn't currently clean up branches, it's entirely possible to even base a series on a severely old branch (so that should get fixed at some point). WDYT? _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
