On Thu, Jan 24, 2019 at 05:00:11PM +0300, Ilya Maximets wrote:
> On 23.01.2019 23:09, Ben Pfaff wrote:
> > Just a style fix.
> > 
> > With this patch, the following reports no hits:
> > 
> > git ls-files | grep '\.[ch]$' | grep -vE 'datapath|sflow' | xargs grep -n 
> > // | grep -vE "http|s/|'|\""
> 
> I'd like this line wrapped. For example, like this:
> 
>   git ls-files | grep '\.[ch]$' | grep -vE 'datapath|sflow' \
>                | xargs grep -n // | grep -vE "http|s/|'|\""
> 
> It's still a valid shell command.

Thanks, fixed.

> Beside that,
> Acked-by: Ilya Maximets <[email protected]>

I applied this to master, thank you!

> P.S. sflow_receiver.c is just a bunch of bad style examples.

Yes, we imported the sflow_* files without modifying them.  The style
doesn't match the usual OVS style, for sure.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to