On Fri, Feb 1, 2019 at 12:49 AM Li,Rongqing <[email protected]> wrote:
> > > 发件人: Darrell Ball [mailto:[email protected]] > 发送时间: 2019年2月1日 16:25 > 收件人: Li,Rongqing <[email protected]> > 抄送: ovs dev <[email protected]> > 主题: Re: [ovs-dev] [PATCH] conntrack: compute hash value once when calling > conn_key_lookup > > > The function comment says it all: > > /* Typical usage of this helper is in non per-packet code; > > * this is because the bucket lock needs to be held for lookup > > * and a hash would have already been needed. Hence, this function > > * is just intended for code clarity. */ > > > > Does it mean that the hash value will be changed ? No > if it is true, should we release original lock, and relock lock for new > hash value? > Also, the full context is this: The function is also written with the intention to remove all the 'bucket' stuff in a future patchset (check the ML). It turns out, the function will get deprecated in future. > > Thanks > > -RongQing > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
