> Run ovs-tcpdump without --span, and it throws the following
> exception. Define mirror_select_all to avoid the error.
>
> Traceback (most recent call last):
> File "/usr/local/bin/ovs-tcpdump", line 488, in <module>
> main()
> File "/usr/local/bin/ovs-tcpdump", line 454, in main
> mirror_select_all)
> UnboundLocalError: local variable 'mirror_select_all' referenced before
> assignment
>
> Fixes: 0475db71c650 ("ovs-tcpdump: Add --span to mirror all ports on bridge.")
>
> Signed-off-by: Hyong Youb Kim <[email protected]>
> ---
> v2:
> * fix a typo: with -> without
> * resend after subscribing to dev to avoid ovs-dev in From:
>
> utilities/ovs-tcpdump.in | 1 +
> 1 file changed, 1 insertion(+)
Thanks for the fix,
Acked-by: Ilya Maximets <[email protected]>
Regarding checkpatch. Looks like it's a patchwork issue.
It has mail-list email in a form field. Mail-list itself shows correct e-mail.
I hope, maintainers will use correct one while applying the patch, if needed.
Another option (workaround): You may add "From: Name <e-mail>" as a first line
of the commit-message. This should be correctly treated by git in any case.
> diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in
> index 22f249f58..269c252f8 100755
> --- a/utilities/ovs-tcpdump.in
> +++ b/utilities/ovs-tcpdump.in
> @@ -379,6 +379,7 @@ def main():
>
> skip_next = False
> mirror_interface = None
> + mirror_select_all = False
> dump_cmd = 'tcpdump'
>
> for cur, nxt in argv_tuples(sys.argv[1:]):
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
