On Thu, Jan 31, 2019 at 03:49:39PM -0800, Ashish Varma wrote: > OVS supports Nicira version of Flow Monitor feature which allows an OpenFlow > controller to keep track of any changes in the flow table. (The changes can > done by the controller itself or by any other controller connected to OVS.) > This patch adds support for the OpenFlow 1.4+ OFPMP_FLOW_MONITOR multipart > message. > Also added support in "ovs-ofctl monitor" to send OpenFlow 1.4+ messages to > OVS. > Added unit test cases to test the OpenFlow version of Flow Monitor messages. > > Signed-off-by: Ashish Varma <[email protected]>
Thanks for the revision! It will be nice to finally have this feature! Since parse_flow_monitor_request() already has a 'usable_protocols' parameter, I would suggest using that to limit the support for out_group, rather than putting a special case into ofctl_monitor(). I would add an example of the new message to tests/ofp-print.at. I think we talked about supporting flow monitors in OF1.1, 1.2, and 1.3. I seem to recall that you plan to add that afterward, in a separate patch. Is that correct? I hope that, if so, you can start work on it soon after this patch is accepted. I would add an item to NEWS. Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
