发件人: Darrell Ball [mailto:[email protected]] 发送时间: 2019年2月1日 23:25 收件人: Li,Rongqing <[email protected]> 抄送: ovs dev <[email protected]> 主题: Re: [ovs-dev] [PATCH] conntrack: Remove unnecessary check in process_ftp_ctl_v4
On Fri, Feb 1, 2019 at 1:07 AM Li,Rongqing <[email protected]<mailto:[email protected]>> wrote: 发件人: Darrell Ball [mailto:[email protected]<mailto:[email protected]>] 发送时间: 2019年2月1日 16:15 收件人: Li,Rongqing <[email protected]<mailto:[email protected]>> 抄送: ovs dev <[email protected]<mailto:[email protected]>> 主题: Re: [ovs-dev] [PATCH] conntrack: Remove unnecessary check in process_ftp_ctl_v4 >This was intentionally done to be documentative and also make it hard to break; >this code path sees a tiny number of packets. >I am not sure there is much to gain by removing it and adding in lieu of >comments ? gain for packets is little, but step by step. And it can reduce unnessesary codes, make a newbie to easy study I agree; the useless range check can also be considered misleading, in retrospect. Dropping port_lo_hs should not be that confusing. Can you resend the patch with the missing 'Co-authored-by' tag. Co-authored-by: Wang Li <[email protected]<mailto:[email protected]>> OK ,thanks -RongQing _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
