Not a full review. Just a few notes about docs. See inline. Best regards, Ilya Maximets.
On 11.02.2019 5:56, Darrell Ball wrote: > Fragmentation handling is added for supporting conntrack. > Both v4 and v6 are supported. > > After discussion with several people, I decided to not store > configuration state in the database to be more consistent with > the kernel in future, similarity with other conntrack configuration > which will not be in the database as well and overall simplicity. > Accordingly, fragmentation handling is enabled by default. > > This patch enables fragmentation tests for the userspace datapath. > > Signed-off-by: Darrell Ball <[email protected]> > --- > Documentation/faq/releases.rst | 49 +- > NEWS | 10 + > include/sparse/netinet/ip6.h | 1 + > lib/automake.mk | 4 +- > lib/conntrack.c | 20 +- > lib/conntrack.h | 4 + > lib/ct-dpif.c | 58 +- > lib/ct-dpif.h | 12 +- > lib/dpctl.c | 215 +++++- > lib/dpctl.man | 36 + > lib/dpif-netdev.c | 65 +- > lib/dpif-netlink.c | 9 +- > lib/dpif-provider.h | 53 +- > lib/ipf.c | 1579 > ++++++++++++++++++++++++++++++++++++++ > lib/ipf.h | 60 ++ > tests/system-kmod-macros.at | 46 +- > tests/system-traffic.at | 51 +- > tests/system-userspace-macros.at | 186 ++++- > 18 files changed, 2378 insertions(+), 80 deletions(-) > create mode 100644 lib/ipf.c > create mode 100644 lib/ipf.h > > diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst > index 86f09e6..4c5ca51 100644 > --- a/Documentation/faq/releases.rst > +++ b/Documentation/faq/releases.rst > @@ -105,31 +105,30 @@ Q: Are all features available with all datapaths? > The following table lists the datapath supported features from an Open > vSwitch user's perspective. > > - ===================== ============== ============== ========= ======= > - Feature Linux upstream Linux OVS tree Userspace Hyper-V > - ===================== ============== ============== ========= ======= > - NAT 4.6 YES Yes NO > - Connection tracking 4.3 YES PARTIAL PARTIAL > - Tunnel - LISP NO YES NO NO > - Tunnel - STT NO YES NO YES > - Tunnel - GRE 3.11 YES YES YES > - Tunnel - VXLAN 3.12 YES YES YES > - Tunnel - Geneve 3.18 YES YES YES > - Tunnel - GRE-IPv6 4.18 YES YES NO > - Tunnel - VXLAN-IPv6 4.3 YES YES NO > - Tunnel - Geneve-IPv6 4.4 YES YES NO > - Tunnel - ERSPAN 4.18 YES YES NO > - Tunnel - ERSPAN-IPv6 4.18 YES YES NO > - QoS - Policing YES YES YES NO > - QoS - Shaping YES YES NO NO > - sFlow YES YES YES NO > - IPFIX 3.10 YES YES NO > - Set action YES YES YES PARTIAL > - NIC Bonding YES YES YES YES > - Multiple VTEPs YES YES YES YES > - Meters 4.15 YES YES NO > - Conntrack zone limit 4.18 YES NO NO > - ===================== ============== ============== ========= ======= > + ========================== ============== ============== ========= > ======= > + Feature Linux upstream Linux OVS tree Userspace > Hyper-V > + ========================== ============== ============== ========= > ======= > + Connection tracking 4.3 YES YES YES > + Conntrack Fragment Reass. 4.3 YES YES YES > + NAT 4.6 YES YES NO > + Conntrack zone limit 4.18 YES NO NO > + Tunnel - LISP NO YES NO NO > + Tunnel - STT NO YES NO YES > + Tunnel - GRE 3.11 YES YES YES > + Tunnel - VXLAN 3.12 YES YES YES > + Tunnel - Geneve 3.18 YES YES YES > + Tunnel - GRE-IPv6 NO NO YES NO > + Tunnel - VXLAN-IPv6 4.3 YES YES NO > + Tunnel - Geneve-IPv6 4.4 YES YES NO > + QoS - Policing YES YES YES NO > + QoS - Shaping YES YES NO NO > + sFlow YES YES YES NO > + IPFIX 3.10 YES YES NO > + Set action YES YES YES > PARTIAL > + NIC Bonding YES YES YES YES > + Multiple VTEPs YES YES YES YES > + Meters 4.15 YES YES NO > + ========================== ============== ============== ========= > ======= Looks like the patch was rebased inaccurately. New table contains no features from kernel 4.18, ERSPAN is missing and so on. > > Do note, however: > > diff --git a/NEWS b/NEWS > index ccc0bfb..80f059f 100644 > --- a/NEWS > +++ b/NEWS > @@ -35,6 +35,16 @@ v2.11.0 - xx xxx xxxx > - add the capability to specify a static ip address and get the L2 one > allocated dynamically using the following syntax: > ovn-nbctl lsp-set-addresses <port> "dynamic <IP>" > + - Userspace datapath: > + * Add v4/v6 fragmentation support for conntrack. > + * New ovs-appctl "dpctl/ipf-set-enabled" and "dpctl/ipf-set-disabled" > + commands for userspace datapath conntrack fragmentation support. > + * New "ovs-appctl dpctl/ipf-set-min-frag" command for userspace > + datapath conntrack fragmentation support. > + * New "ovs-appctl dpctl/ipf-set-max-nfrags" command for userspace > datapath > + conntrack fragmentation support. > + * New "ovs-appctl dpctl/ipf-get-status" command for userspace datapath > + conntrack fragmentation support. Above should go to the "Post-v2.11.0" section. [...] _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
