Fragmentation support for userspace datapath conntrack is added; both
v4 and v6 are supported.
Fragmentation handling is enabled by default and a command is supplied
to disable it.
Other commands allow setting the maximum number of fragments to be
tracked, the minimum fragment size and retrieving the state of the
fragmentation module; see the patches for additional details.
Fragmentation tests for the userspace datapath are enabled
by the patches and other test enhancements are added.
v13: Addressed review comments.
Cleaned up some unnecessary code.
Fixed a bug in ipf_reassemble_v4_frags() ipf_reassemble_v6_frags()
where L2 padding for the constructed v4/v6 packets was not reset.
v12: Fixed last minute search and replace error to shorten line length:
- pb->dnsteal)) {
+ pb->do_not_steal)) {
v11: Fixed the 4 address sanitizer failures; these were corner cases,
but valid use cases. Added a field to dp-packet packet batch to
address this with a separate patch.
Split out another patch in dp-packet for another new api to
check for full batches.
v10: Addressed Ben's review comments.
Merged patches 6 and onwards per request.
Note 4 tests are flagged by address santizer, but are an artifact
of the packet-out test methodology.
Also allowed supporting multiple instances of the fragmentation
module per vswitchd instance; a possible real use case is running
both DPDK and future AF_XDP at the same time
v9: Exported ipf status type to dpif-provider.h for code maintenance
reasons vs datatype info. hiding (code review suggestion;
Thanks Justin).
Changed counters to 64 bit, per intention (oops) and added a patch
to support 64 bit atomics (code review; good catch Justin).
Merged code for cleanup thread into patches.
Cleanup dpctl_ct_ipf_get_status() usage; 'verbose' usage vs '-m'.
Added a patch to cleanup opt_dpif_open() and callers.
Enhanced comment for 'ipf-set-min-frag'
Minor cleanups.
Rebase.
v8: Fix argument index (-1 vs -2) for recently added function
ipf_set_enabled__().
Eliminate spaces around '|' for 'v4 | v6'.
Reduce performance impact for non-fragments to approx zero.
v7: Address review comments (Thanks Justin).
Rebase.
Fix a couple bugs.
Some enhancements.
v6: Rebase
Folded patch 4 and some test enablement into patch 3 and brought
an earlier patch forward in sequence
Enable fragmentation by default
Cleanup
v5: Added a sub-feature to optionally dump fragmentation lists.
This is useful for DOS forensics and debugging.
The testing coverage was also extended including checking
more counters and frag list occupancies.
Fixed a few bugs:
1/ Handle dpdk mempool source restrictions for a batch of
packets from multiple sources; this also brings in a purge
frag list function to handle pathological cases of stuck frags.
2/ ipf_destroy was missing packet frees for frag lists.
3/ A setting of CS_INVALID was missing for expired packets -
I mentioned this earlier for version 4.
Some enhancements and coding standards changes for Patch 3.
v4: Add V6 support to the patches.
Fix possible race cleanup bug when the user disables
fragmentation and there are list occupancies, not cleaned up
yet.
Add missed orig tuple fields for copy from reassembled packet
to fragments.
Fix an fragment list increment check - shoiuld have been "> 0"
rather then "!= 0".
Fix max frags calculation in case of theoretical corner case.
Add proper lock annotations.
Made some other improvements while adding V6 support.
v3: Patch 2 was updated:
Remove "XXX" todo items by implementing the ones needed,
including realloc frag_list contexts to save memory.
Fix related bug with max_frag_list_size when min_frag_size is
reconfigured.
Tighten ip_tot_len sanity check for reassembled packets which
was more loose than intended.
Add another sanity check for fragment ip_tot_len; even though
it be redundant, add for completeness.
v2: Few fixes, improvements and cleanups.
Darrell Ball (8):
dp-packet: Add const qualifiers for checksum apis.
flow: Enhance parse_ipv6_ext_hdrs.
tests: Add missed local stack checks.
conntrack: Reword conntrack_execute() description.
ovs-atomic: Add 64 bit apis.
dp-packet: Add 'dp_packet_batch_is_full()' api.
dp-packet: Add 'do_not_steal' packet batch flag.
Userspace datapath: Add fragmentation handling.
Documentation/faq/releases.rst | 51 +-
NEWS | 10 +-
include/sparse/netinet/ip6.h | 1 +
lib/automake.mk | 4 +-
lib/conntrack.c | 26 +-
lib/conntrack.h | 4 +
lib/ct-dpif.c | 58 +-
lib/ct-dpif.h | 12 +-
lib/dp-packet.h | 24 +-
lib/dpctl.c | 215 +++++-
lib/dpctl.man | 36 +
lib/dpif-netdev.c | 66 +-
lib/dpif-netlink.c | 9 +-
lib/dpif-provider.h | 53 +-
lib/flow.c | 44 +-
lib/flow.h | 3 +-
lib/ipf.c | 1528 ++++++++++++++++++++++++++++++++++++++
lib/ipf.h | 63 ++
lib/ovs-atomic.h | 36 +
tests/system-kmod-macros.at | 46 +-
tests/system-traffic.at | 53 +-
tests/system-userspace-macros.at | 186 ++++-
22 files changed, 2425 insertions(+), 103 deletions(-)
create mode 100644 lib/ipf.c
create mode 100644 lib/ipf.h
--
1.9.1
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
