On Fri, Feb 15, 2019 at 08:48:41AM +0000, Eli Britstein wrote: > Generate datapath ovs key fields macros as a pre-step of retrieving > field information, with no functional change. > > Signed-off-by: Eli Britstein <[email protected]> > Reviewed-by: Roi Dayan <[email protected]>
Thanks for the patch. The generated header file has a lot of identifiers whose names begin with __. Please remove these prefixes since they are reserved to the C implementation. (I know the kernel uses such prefixes. Arguably, it should not.) __OVS_KEY_FIELDS_END isn't used anywhere. I suggest removing it. Thanks, Ben. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
