> On Mon, Feb 04, 2019 at 11:50:22AM -0500, Aaron Conole wrote:
>> Hyong Youb Kim via dev <ovs-dev at openvswitch.org> writes:
>>
>> > From: Hyong Youb Kim <hyonkim at cisco.com>
>> >
>> > Run ovs-tcpdump without --span, and it throws the following
>> > exception. Define mirror_select_all to avoid the error.
>> >
>> > Traceback (most recent call last):
>> > File "/usr/local/bin/ovs-tcpdump", line 488, in <module>
>> > main()
>> > File "/usr/local/bin/ovs-tcpdump", line 454, in main
>> > mirror_select_all)
>> > UnboundLocalError: local variable 'mirror_select_all' referenced before
>> > assignment
>> >
>> > Fixes: 0475db71c650 ("ovs-tcpdump: Add --span to mirror all ports on
>> > bridge.")
>> >
>> > Signed-off-by: Hyong Youb Kim <hyonkim at cisco.com>
>> > Acked-by: Ilya Maximets <i.maximets at samsung.com>
>> > ---
>>
>> Acked-by: Aaron Conole <aconole at redhat.com>
>
> Thanks, Hyong (and Aaron). I applied this to master and backported it
> as far as it would go.
Hi Ben.
Looks like you backported this patch too far. The original patch that
is fixed here exists only starting from 2.11.
On branches 2.6 - 2.10 'make flake8-check' fails now:
utilities/ovs-tcpdump.in:380:5: F841 local variable 'mirror_select_all'
is assigned to but never used
Makefile:6401: recipe for target 'flake8-check' failed
We probably should revert this fix from branches 2.6 to 2.10.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
