On Wed, Feb 20, 2019 at 7:44 PM Darrell Ball <[email protected]> wrote:
> I was able to see it with the address sanitizer as a false positive > > You can backport > > faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d > > as far back as 2.8 > hmm, after rebase, I can see this pretty consistently with '-O2' with various gcc versions without -O2, I do not see it. anyways pls backport faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d as far back as 2.8; 2.8 might need a minor adjustment, > > On Wed, Feb 20, 2019 at 6:17 PM Justin Pettit <[email protected]> wrote: > >> Hi, Darrell. You've handled most of the userspace conntrack work >> lately. Are you able to reproduce this issue? My compiler build it >> without any problem. >> >> Thanks, >> >> --Justin >> >> >> Begin forwarded message: >> >> *From: *0-day Robot <[email protected]> >> *Subject: **Re: Set release date for 2.10.2.* >> *Date: *February 20, 2019 at 5:57:54 PM MST >> *To: *Justin Pettit <[email protected]> >> *Cc: *[email protected] >> >> Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out >> your patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >> >> build: >> mv -f $depbase.Tpo $depbase.Plo >> libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I >> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra >> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum >> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes >> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers >> -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror >> -g -O2 -MT lib/conntrack-tcp.lo -MD -MP -MF lib/.deps/conntrack-tcp.Tpo -c >> lib/conntrack-tcp.c -o lib/conntrack-tcp.o >> depbase=`echo lib/conntrack-other.lo | sed >> 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ >> /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 >> -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib >> -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith >> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter >> -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition >> -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing >> -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT >> lib/conntrack-other.lo -MD -MP -MF $depbase.Tpo -c -o >> lib/conntrack-other.lo lib/conntrack-other.c &&\ >> mv -f $depbase.Tpo $depbase.Plo >> libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I >> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra >> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum >> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes >> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers >> -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror >> -g -O2 -MT lib/conntrack-other.lo -MD -MP -MF lib/.deps/conntrack-other.Tpo >> -c lib/conntrack-other.c -o lib/conntrack-other.o >> depbase=`echo lib/conntrack.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ >> /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 >> -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib >> -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith >> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter >> -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition >> -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing >> -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT >> lib/conntrack.lo -MD -MP -MF $depbase.Tpo -c -o lib/conntrack.lo >> lib/conntrack.c &&\ >> mv -f $depbase.Tpo $depbase.Plo >> libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I >> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra >> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum >> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes >> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers >> -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror >> -g -O2 -MT lib/conntrack.lo -MD -MP -MF lib/.deps/conntrack.Tpo -c >> lib/conntrack.c -o lib/conntrack.o >> lib/conntrack.c: In function 'handle_ftp_ctl': >> lib/conntrack.c:3164:18: error: 'addr_offset_from_ftp_data_start' may be >> used uninitialized in this function [-Werror=maybe-uninitialized] >> modify_packet(pkt, ftp_data_start + addr_offset_from_ftp_data_start, >> ^ >> lib/conntrack.c:3185:12: note: 'addr_offset_from_ftp_data_start' was >> declared here >> size_t addr_offset_from_ftp_data_start; >> ^ >> lib/conntrack.c: At top level: >> cc1: error: unrecognized command line option >> "-Wno-null-pointer-arithmetic" [-Werror] >> cc1: all warnings being treated as errors >> make[2]: *** [lib/conntrack.lo] Error 1 >> make[2]: Leaving directory >> `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace' >> make[1]: *** [all-recursive] Error 1 >> make[1]: Leaving directory >> `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace' >> make: *** [all] Error 2 >> >> >> Please check this out. If you feel there has been an error, please email >> [email protected] <[email protected]> >> >> Thanks, >> 0-day Robot >> >> >> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
