Flavio, Following your review - v2 was sent, rebased on to of master. Empty lines were removed
> -----Original Message----- > From: Flavio Leitner <[email protected]> > Sent: Wednesday, February 20, 2019 3:26 PM > To: Ophir Munk <[email protected]> > Cc: [email protected]; Shahaf Shuler <[email protected]>; > Roni Bar Yanai <[email protected]>; Ilya Maximets > <[email protected]> > Subject: Re: [ovs-dev] [PATCH v1 2/3] netdev-dpdk: Move offloading-code > to a new file > > On Mon, Feb 18, 2019 at 04:16:02PM +0000, Ophir Munk wrote: > > From: Roni Bar Yanai <[email protected]> > > > > Hardware offloading-code is moved to a new file called > > netdev-rte-offloads.c. The original offloading-code is copied as is > > from the netdev-dpdk.c file into the new file where future > > offloading-code should be added as well. The netdev-dpdk.c file will > > remain unchanged as new offloading-code is added. > > > > Reviewed-by: Asaf Penso <[email protected]> > > Signed-off-by: Roni Bar Yanai <[email protected]> > > Signed-off-by: Ophir Munk <[email protected]> ... > > +out: > > + free(patterns.items); > > + free(actions.actions); > > + return ret; > > +} > > + > > + > > + > > Extra empty lines here. However, this patch doesn't apply anymore so I > can't review it properly. Could you please rebase? > > Thanks > fbl > Done in v2 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
