On Mon, Feb 18, 2019 at 12:03:42PM -0500, Aaron Conole wrote: > Ilya Maximets <[email protected]> writes: > > > ' -(' matches a single character in the range between ' ' (index 32) > > and '(' (index 40). This leads to the false positive: > > > > WARNING: Line lacks whitespace around operator > > #445 FILE: ovsdb/monitor.c:573: > > if (--mcs->n_refs == 0) { > > > > Need to escape '-' to have a right behaviour. > > This patch additionally escapes all other '-' chars in the similar > > regexes and makes them be one per line to ease the review in case of > > future changes. > > > > Basic unit tests added. > > > > CC: Joe Stringer <[email protected]> > > Fixes: 0d7b16daea50 ("checkpatch: Check for infix operator whitespace.") > > Signed-off-by: Ilya Maximets <[email protected]> > > --- > > Acked-by: Aaron Conole <[email protected]> > > Thanks for fixing this, Ilya!
Thanks, applied to master. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
